@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix broken handle rendering in Ponder
Summary: Ref T5817. This just fixes the markup in emails, the overall behavior still isn't great. I don't want to spend to much time on Ponder until it ends up somewhere nearer the top of the priority queue.
Test Plan: Viewed feed stories and emails, no stray/clearly-broken HTML.
Reviewers: btrahan
Reviewed By: btrahan
Subscribers: epriestley
Maniphest Tasks: T5817
Differential Revision: https://secure.phabricator.com/D10231
+5
-9
+3
-1
src/applications/ponder/phid/PonderAnswerPHIDType.php
+3
-1
src/applications/ponder/phid/PonderAnswerPHIDType.php
···
29
29
$answer = $objects[$phid];
30
30
31
31
$id = $answer->getID();
32
+
$question = $answer->getQuestion();
33
+
$question_title = $question->getFullTitle();
32
34
33
-
$handle->setName("Answer {$id}");
35
+
$handle->setName("{$question_title} (Answer {$id})");
34
36
$handle->setURI($answer->getURI());
35
37
}
36
38
}
+2
-8
src/applications/ponder/storage/PonderAnswerTransaction.php
+2
-8
src/applications/ponder/storage/PonderAnswerTransaction.php
···
54
54
55
55
switch ($this->getTransactionType()) {
56
56
case self::TYPE_CONTENT:
57
-
$answer = $story->getObject($object_phid);
58
-
$question = $answer->getQuestion();
59
-
$answer_handle = $this->getHandle($object_phid);
60
-
$link = $answer_handle->renderLink(
61
-
$question->getFullTitle());
62
-
63
57
return pht(
64
-
'%s updated their answer to %s',
58
+
'%s updated %s.',
65
59
$this->renderHandleLink($author_phid),
66
-
$link);
60
+
$this->renderHandleLink($object_phid));
67
61
}
68
62
69
63
return parent::getTitleForFeed($story);