+1 -1

src/applications/dashboard/interface/PhabricatorDashboardPanelContainerInterface.php

reviewed

··· 5 5 /** 6 6 * Return a list of Dashboard Panel PHIDs used by this container. 7 7 * 8 8 - * @return list<phid> 8 8 + * @return list<string> Dashboard panel PHIDs used by this container. 9 9 */ 10 10 public function getDashboardPanelContainerPanelPHIDs(); 11 11

+2 -2

src/applications/doorkeeper/worker/DoorkeeperJIRAFeedWorker.php

reviewed

··· 145 145 /** 146 146 * Get a list of users to act as when publishing into JIRA. 147 147 * 148 148 - * @return list<phid> Candidate user PHIDs to act as when publishing this 149 149 - * story. 148 148 + * @return list<string> Candidate user PHIDs to act as when publishing this 149 149 + * story. 150 150 * @task internal 151 151 */ 152 152 private function findUsersToPossess() {

+1 -1

src/applications/harbormaster/interface/HarbormasterBuildableInterface.php

reviewed

··· 11 11 * buildable (the diff), but for commits the buildable (the commit) is more 12 12 * meaningful than the container (the repository). 13 13 * 14 14 - * @return phid Related object PHID most meaningful for human viewers. 14 14 + * @return string Related object PHID most meaningful for human viewers. 15 15 */ 16 16 public function getHarbormasterBuildableDisplayPHID(); 17 17

+2 -2

src/applications/maniphest/query/ManiphestTaskQuery.php

reviewed

··· 809 809 * ...we ignore the single project, as every result is in that project. (In 810 810 * the case that there are several "any" projects, we do not ignore them.) 811 811 * 812 812 - * @return list<phid> Project PHIDs which should be ignored in query 813 813 - * construction. 812 812 + * @return list<string> Project PHIDs which should be ignored in query 813 813 + * construction. 814 814 */ 815 815 private function getIgnoreGroupedProjectPHIDs() { 816 816 // Maybe we should also exclude the "OPERATOR_NOT" PHIDs? It won't

+1 -1

src/applications/metamta/replyhandler/PhabricatorMailReplyHandler.php

reviewed

··· 276 276 * 277 277 * @param list<string> $to List of To PHIDs. 278 278 * @param list<string> $cc List of CC PHIDs. 279 279 - * @return pair<list<phid>, list<phid>> Expanded PHID lists. 279 279 + * @return pair<list<string>, list<string>> Expanded PHID lists. 280 280 */ 281 281 private function expandRecipientPHIDs(array $to, array $cc) { 282 282 $to_result = array();

+2 -2

src/applications/metamta/storage/PhabricatorMetaMTAMail.php

reviewed

··· 826 826 * Note that this expands recipients into their members, because delivery 827 827 * is never directly attempted to aggregate actors like projects. 828 828 * 829 829 - * @return list<phid> A list of all recipients to whom delivery will be 830 830 - * attempted. 829 829 + * @return list<string> A list of all recipients to whom delivery will be 830 830 + * attempted. 831 831 * @task recipients 832 832 */ 833 833 public function buildRecipientList() {

+1 -1

src/applications/phid/query/PhabricatorObjectQuery.php

reviewed

··· 198 198 * 199 199 * @param PhabricatorUser $viewer Viewer. 200 200 * @param list<string> $phids List of ostensibly valid PHIDs. 201 201 - * @return list<phid> List of invalid or restricted PHIDs. 201 201 + * @return list<string> List of invalid or restricted PHIDs. 202 202 */ 203 203 public static function loadInvalidPHIDsForViewer( 204 204 PhabricatorUser $viewer,

+3 -3

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

reviewed

··· 734 734 * @param string $key Key to read in the request. 735 735 * @param list<string> $allow_types (optional) Other permitted PHID type 736 736 * constants. 737 737 - * @return list<phid> List of user PHIDs and selector functions. 737 737 + * @return list<string> List of user PHIDs and selector functions. 738 738 * @task read 739 739 */ 740 740 protected function readUsersFromRequest( ··· 785 785 * 786 786 * @param AphrontRequest $request Request to read PHIDs from. 787 787 * @param string $key Key to read in the request. 788 788 - * @return list<phid> List of object PHIDs. 788 788 + * @return list<string> List of object PHIDs. 789 789 * @task read 790 790 */ 791 791 protected function readSubscribersFromRequest( ··· 810 810 * @param string $key Key to read in the request. 811 811 * @param list<string> $allow_types (optional) List of permitted PHID 812 812 * type constants. 813 813 - * @return list<phid> List of object PHIDs. 813 813 + * @return list<string> List of object PHIDs. 814 814 * 815 815 * @task read 816 816 */

+1 -1

src/applications/spaces/query/PhabricatorSpacesNamespaceQuery.php

reviewed

··· 213 213 * can intentionally pass any value in (including `null`). 214 214 * 215 215 * @param wild $object 216 216 - * @return phid|null 216 216 + * @return string|null Space PHID of the object, or null. 217 217 */ 218 218 public static function getObjectSpacePHID($object) { 219 219 if (!$object) {

+1 -1

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

reviewed

··· 4762 4762 * conflicting projects. 4763 4763 * 4764 4764 * @param list<string> $phids List of project PHIDs. 4765 4765 - * @return list<phid> List with conflicts removed. 4765 4765 + * @return list<string> List of project PHIDs with conflicts removed. 4766 4766 */ 4767 4767 private function applyProjectConflictRules(array $phids) { 4768 4768 if (!$phids) {

+2 -2

src/infrastructure/edges/query/PhabricatorEdgeQuery.php

reviewed

··· 123 123 * 124 124 * @param string $src_phid Source PHID. 125 125 * @param string $edge_type Edge type constant. 126 126 - * @return list<phid> List of destination PHIDs. 126 126 + * @return list<string> List of destination PHIDs. 127 127 */ 128 128 public static function loadDestinationPHIDs($src_phid, $edge_type) { 129 129 $edges = id(new PhabricatorEdgeQuery()) ··· 260 260 * select all. 261 261 * @param list $types (optional) List of edge types to select, or empty to 262 262 * select all. 263 263 - * @return list<phid> List of matching destination PHIDs. 263 263 + * @return list<string> List of matching destination PHIDs. 264 264 */ 265 265 public function getDestinationPHIDs( 266 266 array $src_phids = array(),

+2 -2

src/infrastructure/query/policy/PhabricatorPolicyAwareQuery.php

reviewed

··· 433 433 * between objects which do not exist (or, at least, were filtered at the 434 434 * content level) and objects which exist but aren't visible. 435 435 * 436 436 - * @return map<phid, phid> Map of object PHIDs which were filtered 436 436 + * @return map<string, string> Map of object PHIDs which were filtered 437 437 * by policies. 438 438 * @task exec 439 439 */ ··· 552 552 * 553 553 * PHIDs which are "in flight" are actively being queried for. 554 554 * 555 555 - * @return map<phid, phid> PHIDs currently in flight. 555 555 + * @return map<string, string> PHIDs currently in flight. 556 556 */ 557 557 public function getPHIDsInFlight() { 558 558 $results = $this->inFlightPHIDs;

+1 -1

src/infrastructure/storage/lisk/LiskDAO.php

reviewed

··· 1187 1187 /** 1188 1188 * Generate a new PHID, used by CONFIG_AUX_PHID. 1189 1189 * 1190 1190 - * @return phid Unique, newly allocated PHID. 1190 1190 + * @return string Unique, newly allocated PHID. 1191 1191 * 1192 1192 * @task hook 1193 1193 */