@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Allow "Move Tasks to Column..." to prompt for MFA
Summary:
Ref T13074. Currently, if you "Move Tasks to Column..." on a board and some of the tasks require MFA to edit, the workflow fatals out.
After this change, it works properly. You still have to answer a separate MFA prompt for //each// task, which is a little ridiculous, but at least doable. A reasonable future refinement would be to batch these MFA prompts, but this is currently the only use case for that.
Test Plan: Set a task to a "Require MFA" status, bulk-moved it with other tasks on a workboard. Was prompted, answered MFA prompt, got a move.
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T13074
Differential Revision: https://secure.phabricator.com/D20282
+3
-2
+3
-2
src/applications/project/controller/PhabricatorProjectBoardViewController.php
+3
-2
src/applications/project/controller/PhabricatorProjectBoardViewController.php
···
328
328
$columns = null;
329
329
$errors = array();
330
330
331
-
if ($request->isFormPost()) {
331
+
if ($request->isFormOrHiSecPost()) {
332
332
$move_project_phid = head($request->getArr('moveProjectPHID'));
333
333
if (!$move_project_phid) {
334
334
$move_project_phid = $request->getStr('moveProjectPHID');
···
425
425
->setActor($viewer)
426
426
->setContinueOnMissingFields(true)
427
427
->setContinueOnNoEffect(true)
428
-
->setContentSourceFromRequest($request);
428
+
->setContentSourceFromRequest($request)
429
+
->setCancelURI($cancel_uri);
429
430
430
431
$editor->applyTransactions($move_task, $xactions);
431
432
}