@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
be careful of received mail object in error cases too
Summary:
we're tracking down a fatal caused by the mandatory
attachments array parameter change in the reply handler and
yo dawg, heard you like to fatal in your fatal.
Test Plan:
internal test scenario with xmail -> phabricator
triggered manually.
Reviewers: nh, vrana, epriestley
Reviewed By: epriestley
CC: aran, epriestley
Differential Revision: https://secure.phabricator.com/D4005
+6
-1
+6
-1
src/applications/differential/DifferentialReplyHandler.php
+6
-1
src/applications/differential/DifferentialReplyHandler.php
···
147
147
return $comment->getID();
148
148
149
149
} catch (Exception $ex) {
150
+
if ($this->receivedMail) {
151
+
$error_body = $this->receivedMail->getRawTextBody();
152
+
} else {
153
+
$error_body = $body;
154
+
}
150
155
$exception_mail = new DifferentialExceptionMail(
151
156
$this->getMailReceiver(),
152
157
$ex,
153
-
$this->receivedMail->getRawTextBody());
158
+
$error_body);
154
159
155
160
$exception_mail->setToPHIDs(array($this->getActor()->getPHID()));
156
161
$exception_mail->send();