recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Remove IE6/7 non-standard "_zoom" CSS workaround

Summary:
Phorge does not support these browser versions anymore.

Quoting https://css-tricks.com/almanac/properties/z/zoom/: "Many of the rendering bugs in both IE6 and IE7 could be fixed using zoom. [...] Setting zoom: 1 turned on an internal property called hasLayout, which fixed the problem."
See also https://web.archive.org/web/20150906195720/https://developer.mozilla.org/en-US/docs/Web/CSS/zoom

And while `zoom` is recently seeing standardization per https://developer.mozilla.org/en-US/docs/Web/CSS/zoom there still wouldn't be an underscore prefix character.

Test Plan:
Walk up to the library and dive into some dusty books about the wild early days of CSS.

Also, enjoy the conversation about that line using git blame:

https://we.phorge.it/source/phorge/browse/master/webroot/rsrc/css/aphront/typeahead.css;0aa67025f25d30162309d59b4cbe133b6180b2d7$7 - 2011

https://we.phorge.it/source/phorge/browse/master/webroot/rsrc/css/aphront/typeahead.css;7a9d5f8f2de5e44f4014116a47de4ea870361732$7 - 2013

https://we.phorge.it/source/phorge/browse/master/webroot/rsrc/css/aphront/typeahead.css;3cf6f746f0555b4d73d587972d896de99667fb06$7 - 2014

https://we.phorge.it/source/phorge/browse/master/webroot/rsrc/css/aphront/typeahead.css;7aee92b5e95cfc11059e9ff8788e5e53dc88e84d$7 - 2017

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D25974

Andre Klapper dfe8539c 4bd591e4

+3 -4
+3 -3
resources/celerity/map.php
··· 9 9 'names' => array( 10 10 'conpherence.pkg.css' => '3144a5e2', 11 11 'conpherence.pkg.js' => '020aebcf', 12 - 'core.pkg.css' => '8aed2c92', 12 + 'core.pkg.css' => '3406c4ea', 13 13 'core.pkg.js' => '086da722', 14 14 'dark-console.pkg.js' => '187792c2', 15 15 'differential.pkg.css' => '91ac6214', ··· 35 35 'rsrc/css/aphront/tokenizer.css' => '194e8160', 36 36 'rsrc/css/aphront/tooltip.css' => 'e3f2412f', 37 37 'rsrc/css/aphront/typeahead-browse.css' => 'b7ed02d2', 38 - 'rsrc/css/aphront/typeahead.css' => '8779483d', 38 + 'rsrc/css/aphront/typeahead.css' => '5da109c8', 39 39 'rsrc/css/application/almanac/almanac.css' => '2e050f4f', 40 40 'rsrc/css/application/auth/auth.css' => 'c2f23d74', 41 41 'rsrc/css/application/base/main-menu-view.css' => '741a6bba', ··· 542 542 'aphront-table-view-css' => '0bb61df1', 543 543 'aphront-tokenizer-control-css' => '194e8160', 544 544 'aphront-tooltip-css' => 'e3f2412f', 545 - 'aphront-typeahead-control-css' => '8779483d', 545 + 'aphront-typeahead-control-css' => '5da109c8', 546 546 'application-search-view-css' => '0f7c06d8', 547 547 'auth-css' => 'c2f23d74', 548 548 'bulk-job-css' => '73af99f5',
-1
webroot/rsrc/css/aphront/typeahead.css
··· 4 4 5 5 div.jx-typeahead-hardpoint { 6 6 position: relative; 7 - _zoom: 1; /* Some kind of IE6 fix? */ /* yes */ /* why? */ /* still need? */ 8 7 } 9 8 10 9 div.jx-typeahead-results {