Added isClosed property to maniphest conduit endpoint in order to fix an issue with arcanist when displaying tasks

@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge

phorge phabricator

fork

Summary:
Arcanist is currently displaying all tasks as closed when invoking `arc tasks`.
This is because arcanist is setting the display to closed if there is anything in the `status` property. Adding an isClosed property will allow arcanist to properly display open/closed status on tasks by checking against the isClosed property. The isClosed property will be set according to the closed property that is set on each status in maniphest.

Test Plan:
Invoke the conduit maniphest.info method on any task and insure that:
# The isClosed property is included in the properties
# that it is set properly according to the statuses set for maniphest.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: chad, epriestley, Korvin

Maniphest Tasks: T4744

Differential Revision: https://secure.phabricator.com/D8731

authored by

Brayden Winterton and committed by

epriestley 12 years ago dffbbaf0 01552d85

1 changed file

expand all

src

applications

maniphest

conduit

ConduitAPI_maniphest_Method.php

src/applications/maniphest/conduit/ConduitAPI_maniphest_Method.php

··· 260 260 'ownerPHID' => $task->getOwnerPHID(), 261 261 'ccPHIDs' => $task->getCCPHIDs(), 262 262 'status' => $task->getStatus(), 263 + 'statusName' => ManiphestTaskStatus::getTaskStatusName( 264 + $task->getStatus()), 265 + 'isClosed' => $task->isClosed(), 263 266 'priority' => ManiphestTaskPriority::getTaskPriorityName( 264 267 $task->getPriority()), 265 268 'title' => $task->getTitle(),

Configure Feed

Configure Feed