@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

[Redesign] Update PHUIRemarkupPreviewPanel

Summary: Ref T8099, Adds DocumentView support, and cleans up headers.

Test Plan: Review preview in Legalpad, Phriction, and Maniphest.

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T8099

Differential Revision: https://secure.phabricator.com/D13442

+24 -18
+2 -2
resources/celerity/map.php
··· 145 145 'rsrc/css/phui/phui-pager.css' => 'bea33d23', 146 146 'rsrc/css/phui/phui-pinboard-view.css' => '2495140e', 147 147 'rsrc/css/phui/phui-property-list-view.css' => '1baf23eb', 148 - 'rsrc/css/phui/phui-remarkup-preview.css' => '19ad512b', 148 + 'rsrc/css/phui/phui-remarkup-preview.css' => '0364d508', 149 149 'rsrc/css/phui/phui-spacing.css' => '042804d6', 150 150 'rsrc/css/phui/phui-status.css' => '888cedb8', 151 151 'rsrc/css/phui/phui-tag-view.css' => '402691cc', ··· 789 789 'phui-pager-css' => 'bea33d23', 790 790 'phui-pinboard-view-css' => '2495140e', 791 791 'phui-property-list-view-css' => '1baf23eb', 792 - 'phui-remarkup-preview-css' => '19ad512b', 793 792 'phui-spacing-css' => '042804d6', 794 793 'phui-status-list-view-css' => '888cedb8', 795 794 'phui-tag-view-css' => '402691cc', ··· 826 825 'tokens-css' => '3d0f239e', 827 826 'typeahead-browse-css' => 'd8581d2c', 828 827 'unhandled-exception-css' => '4c96257a', 828 + 'x' => '0364d508', 829 829 ), 830 830 'requires' => array( 831 831 '01774ab2' => array(
+2 -1
src/applications/legalpad/controller/LegalpadDocumentEditController.php
··· 245 245 $preview = id(new PHUIRemarkupPreviewPanel()) 246 246 ->setHeader(pht('Document Preview')) 247 247 ->setPreviewURI($this->getApplicationURI('document/preview/')) 248 - ->setControlID('document-text'); 248 + ->setControlID('document-text') 249 + ->addClass('phui-document-view'); 249 250 250 251 return $this->buildApplicationPage( 251 252 array(
+2 -1
src/applications/phriction/controller/PhrictionEditController.php
··· 264 264 $preview = id(new PHUIRemarkupPreviewPanel()) 265 265 ->setHeader(pht('Document Preview')) 266 266 ->setPreviewURI('/phriction/preview/') 267 - ->setControlID('document-textarea'); 267 + ->setControlID('document-textarea') 268 + ->addClass('phui-document-view'); 268 269 269 270 $crumbs = $this->buildApplicationCrumbs(); 270 271 if ($document->getID()) {
+3 -6
src/view/phui/PHUIRemarkupPreviewPanel.php
··· 87 87 'div', 88 88 array( 89 89 'id' => $preview_id, 90 - 'class' => 'phabricator-remarkup', 90 + 'class' => 'phabricator-remarkup phui-preview-body', 91 91 ), 92 92 $loading); 93 93 94 94 $content = array($header, $preview); 95 95 96 - return id(new PHUIBoxView()) 96 + return id(new PHUIObjectBoxView()) 97 97 ->appendChild($content) 98 - ->setBorder(true) 99 - ->addMargin(PHUI::MARGIN_LARGE) 100 - ->addPadding(PHUI::PADDING_LARGE) 101 - ->addClass('phui-panel-preview'); 98 + ->setCollapsed(true); 102 99 } 103 100 104 101 }
+15 -8
webroot/rsrc/css/phui/phui-remarkup-preview.css
··· 1 1 /** 2 - * @provides phui-remarkup-preview-css 2 + * @provides x 3 3 */ 4 + 5 + .phui-remarkup-preview .phui-object-box { 6 + padding: 0; 7 + } 4 8 5 9 .phui-preview-header { 6 10 font-size: 12px; 7 11 font-weight: bold; 8 - color: #9ca5b5; 12 + color: {$bluetext}; 9 13 text-transform: uppercase; 10 - padding-bottom: 8px; 14 + padding: 8px; 15 + background-color: {$lightgreybackground}; 16 + border-bottom: 1px solid {$thinblueborder}; 11 17 display: block; 18 + border-top-left-radius: 3px; 19 + border-top-right-radius: 3px; 20 + } 21 + 22 + .phui-preview-body { 23 + padding: 16px; 12 24 } 13 25 14 26 .phui-document-inner .phui-preview-header { 15 27 padding: 16px 0 0 16px; 16 - } 17 - 18 - .phui-remarkup-preview-skin-document { 19 - background: transparent; 20 - border: none; 21 28 } 22 29 23 30 .device-phone .phui-panel-preview {