@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Silence a warning about unknown fields in 'getcommitmessage'
Summary: Similar to D8491, some of my new exceptions are a bit too aggressive. See IRC. This one's hitting an edit workflow with 'revisionID' onboard somehow.
Test Plan: Not entirely sure how to hit this, but it won't throw anymore.
Reviewers: btrahan, dctrwatson, zeeg
Reviewed By: zeeg
Subscribers: zeeg, aran, epriestley
Differential Revision: https://secure.phabricator.com/D8514
+3
-5
+3
-5
src/applications/differential/conduit/ConduitAPI_differential_getcommitmessage_Method.php
+3
-5
src/applications/differential/conduit/ConduitAPI_differential_getcommitmessage_Method.php
···
65
65
foreach ($fields as $field => $value) {
66
66
$custom_field = idx($field_map, $field);
67
67
if (!$custom_field) {
68
-
throw new Exception(
69
-
pht(
70
-
'Commit message includes field "%s", but this field does not '.
71
-
'correspond to a known field.',
72
-
$field));
68
+
// Just ignore this, these workflows don't make strong distictions
69
+
// about field editability on the client side.
70
+
continue;
73
71
}
74
72
if ($is_create ||
75
73
$custom_field->shouldOverwriteWhenCommitMessageIsEdited()) {