@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Conpherence - fix possible fatal
Summary: if users have no conpherences I think this is possible? just init it with the rest of the variables we init when we have no conpherence and we should be good to go. fixes T7671.
Test Plan: logicypoo
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Maniphest Tasks: T7671
Differential Revision: https://secure.phabricator.com/D12227
+6
-4
+6
-4
src/applications/conpherence/controller/ConpherenceColumnViewController.php
+6
-4
src/applications/conpherence/controller/ConpherenceColumnViewController.php
···
56
56
$conpherence_id = null;
57
57
$conpherence_phid = null;
58
58
$latest_transaction_id = null;
59
+
$can_edit = false;
59
60
60
61
} else {
61
62
$this->setConpherence($conpherence);
···
78
79
$conpherence_id = $conpherence->getID();
79
80
$conpherence_phid = $conpherence->getPHID();
80
81
$latest_transaction_id = $latest_transaction->getID();
82
+
$can_edit = PhabricatorPolicyFilter::hasCapability(
83
+
$user,
84
+
$conpherence,
85
+
PhabricatorPolicyCapability::CAN_EDIT);
81
86
}
82
87
83
88
$response = array(
···
85
90
'threadID' => $conpherence_id,
86
91
'threadPHID' => $conpherence_phid,
87
92
'latestTransactionID' => $latest_transaction_id,
88
-
'canEdit' => PhabricatorPolicyFilter::hasCapability(
89
-
$user,
90
-
$conpherence,
91
-
PhabricatorPolicyCapability::CAN_EDIT),
93
+
'canEdit' => $can_edit,
92
94
);
93
95
94
96
return id(new AphrontAjaxResponse())->setContent($response);