recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

make Differential comment panel flexible width and nip a bit at other flexible width issues

Summary:
all sorts of stuff

- made comment form width flexible
- made margins element specific rather than part of differential-primary-pane
- made box elements all veritically align left and right until code stuff
- re-factored width calculaton stuff a bunch so only the code section has to suffer from max-width calculations; everything else can flex
- made colspan 3 for rightmost table header element. this is so the "View Options" UI element ends up lining up correctly with the "Show All Lines" element just below

Test Plan: looked at revision view and changeset view and it all looked hot. note I did not test what things looked like with different word wrap values; that should still work given the re-factoring and not re-design here. also toggled haunted panel mode and it looked good.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T2006

Differential Revision: https://secure.phabricator.com/D3866

Bob Trahan e0b9a633 0364ccdd

+138 -116
+41 -41
src/__celerity_resource_map__.php
··· 722 722 ), 723 723 'differential-changeset-view-css' => 724 724 array( 725 - 'uri' => '/res/8ef2b180/rsrc/css/application/differential/changeset-view.css', 725 + 'uri' => '/res/dfc639d1/rsrc/css/application/differential/changeset-view.css', 726 726 'type' => 'css', 727 727 'requires' => 728 728 array( ··· 731 731 ), 732 732 'differential-core-view-css' => 733 733 array( 734 - 'uri' => '/res/2303c309/rsrc/css/application/differential/core.css', 734 + 'uri' => '/res/7901260e/rsrc/css/application/differential/core.css', 735 735 'type' => 'css', 736 736 'requires' => 737 737 array( ··· 782 782 ), 783 783 'differential-revision-comment-css' => 784 784 array( 785 - 'uri' => '/res/ff510704/rsrc/css/application/differential/revision-comment.css', 785 + 'uri' => '/res/5e613a7f/rsrc/css/application/differential/revision-comment.css', 786 786 'type' => 'css', 787 787 'requires' => 788 788 array( ··· 1181 1181 ), 1182 1182 'javelin-behavior-differential-keyboard-navigation' => 1183 1183 array( 1184 - 'uri' => '/res/559fbf58/rsrc/js/application/differential/behavior-keyboard-nav.js', 1184 + 'uri' => '/res/0a013420/rsrc/js/application/differential/behavior-keyboard-nav.js', 1185 1185 'type' => 'js', 1186 1186 'requires' => 1187 1187 array( ··· 1578 1578 ), 1579 1579 'javelin-behavior-phabricator-nav' => 1580 1580 array( 1581 - 'uri' => '/res/6e550189/rsrc/js/application/core/behavior-phabricator-nav.js', 1581 + 'uri' => '/res/3d04f9ab/rsrc/js/application/core/behavior-phabricator-nav.js', 1582 1582 'type' => 'js', 1583 1583 'requires' => 1584 1584 array( ··· 2586 2586 ), 2587 2587 'phabricator-nav-view-css' => 2588 2588 array( 2589 - 'uri' => '/res/766628f5/rsrc/css/aphront/phabricator-nav-view.css', 2589 + 'uri' => '/res/84381dcf/rsrc/css/aphront/phabricator-nav-view.css', 2590 2590 'type' => 'css', 2591 2591 'requires' => 2592 2592 array( ··· 3149 3149 'uri' => '/res/pkg/805a58d7/core.pkg.js', 3150 3150 'type' => 'js', 3151 3151 ), 3152 - '2ba14b3d' => 3152 + '7d861806' => 3153 3153 array( 3154 3154 'name' => 'differential.pkg.css', 3155 3155 'symbols' => ··· 3169 3169 12 => 'differential-local-commits-view-css', 3170 3170 13 => 'inline-comment-summary-css', 3171 3171 ), 3172 - 'uri' => '/res/pkg/2ba14b3d/differential.pkg.css', 3172 + 'uri' => '/res/pkg/7d861806/differential.pkg.css', 3173 3173 'type' => 'css', 3174 3174 ), 3175 - '8136e4a6' => 3175 + 58152763 => 3176 3176 array( 3177 3177 'name' => 'differential.pkg.js', 3178 3178 'symbols' => ··· 3195 3195 15 => 'differential-inline-comment-editor', 3196 3196 16 => 'javelin-behavior-differential-dropdown-menus', 3197 3197 ), 3198 - 'uri' => '/res/pkg/8136e4a6/differential.pkg.js', 3198 + 'uri' => '/res/pkg/58152763/differential.pkg.js', 3199 3199 'type' => 'js', 3200 3200 ), 3201 3201 'c8ce2d88' => ··· 3291 3291 'aphront-dialog-view-css' => '10a01616', 3292 3292 'aphront-error-view-css' => '10a01616', 3293 3293 'aphront-form-view-css' => '10a01616', 3294 - 'aphront-headsup-action-list-view-css' => '2ba14b3d', 3294 + 'aphront-headsup-action-list-view-css' => '7d861806', 3295 3295 'aphront-headsup-view-css' => '10a01616', 3296 3296 'aphront-list-filter-view-css' => '10a01616', 3297 3297 'aphront-pager-view-css' => '10a01616', ··· 3301 3301 'aphront-tokenizer-control-css' => '10a01616', 3302 3302 'aphront-tooltip-css' => '10a01616', 3303 3303 'aphront-typeahead-control-css' => '10a01616', 3304 - 'differential-changeset-view-css' => '2ba14b3d', 3305 - 'differential-core-view-css' => '2ba14b3d', 3306 - 'differential-inline-comment-editor' => '8136e4a6', 3307 - 'differential-local-commits-view-css' => '2ba14b3d', 3308 - 'differential-results-table-css' => '2ba14b3d', 3309 - 'differential-revision-add-comment-css' => '2ba14b3d', 3310 - 'differential-revision-comment-css' => '2ba14b3d', 3311 - 'differential-revision-comment-list-css' => '2ba14b3d', 3312 - 'differential-revision-history-css' => '2ba14b3d', 3313 - 'differential-revision-list-css' => '2ba14b3d', 3314 - 'differential-table-of-contents-css' => '2ba14b3d', 3304 + 'differential-changeset-view-css' => '7d861806', 3305 + 'differential-core-view-css' => '7d861806', 3306 + 'differential-inline-comment-editor' => '58152763', 3307 + 'differential-local-commits-view-css' => '7d861806', 3308 + 'differential-results-table-css' => '7d861806', 3309 + 'differential-revision-add-comment-css' => '7d861806', 3310 + 'differential-revision-comment-css' => '7d861806', 3311 + 'differential-revision-comment-list-css' => '7d861806', 3312 + 'differential-revision-history-css' => '7d861806', 3313 + 'differential-revision-list-css' => '7d861806', 3314 + 'differential-table-of-contents-css' => '7d861806', 3315 3315 'diffusion-commit-view-css' => 'c8ce2d88', 3316 3316 'diffusion-icons-css' => 'c8ce2d88', 3317 - 'inline-comment-summary-css' => '2ba14b3d', 3317 + 'inline-comment-summary-css' => '7d861806', 3318 3318 'javelin-behavior' => 'c50bbf3a', 3319 3319 'javelin-behavior-aphront-basic-tokenizer' => 'dd024ca1', 3320 - 'javelin-behavior-aphront-drag-and-drop' => '8136e4a6', 3321 - 'javelin-behavior-aphront-drag-and-drop-textarea' => '8136e4a6', 3320 + 'javelin-behavior-aphront-drag-and-drop' => '58152763', 3321 + 'javelin-behavior-aphront-drag-and-drop-textarea' => '58152763', 3322 3322 'javelin-behavior-aphront-form-disable-on-submit' => '805a58d7', 3323 3323 'javelin-behavior-audit-preview' => '5e68be89', 3324 - 'javelin-behavior-differential-accept-with-errors' => '8136e4a6', 3325 - 'javelin-behavior-differential-add-reviewers-and-ccs' => '8136e4a6', 3326 - 'javelin-behavior-differential-comment-jump' => '8136e4a6', 3327 - 'javelin-behavior-differential-diff-radios' => '8136e4a6', 3328 - 'javelin-behavior-differential-dropdown-menus' => '8136e4a6', 3329 - 'javelin-behavior-differential-edit-inline-comments' => '8136e4a6', 3330 - 'javelin-behavior-differential-feedback-preview' => '8136e4a6', 3331 - 'javelin-behavior-differential-keyboard-navigation' => '8136e4a6', 3332 - 'javelin-behavior-differential-populate' => '8136e4a6', 3333 - 'javelin-behavior-differential-show-more' => '8136e4a6', 3324 + 'javelin-behavior-differential-accept-with-errors' => '58152763', 3325 + 'javelin-behavior-differential-add-reviewers-and-ccs' => '58152763', 3326 + 'javelin-behavior-differential-comment-jump' => '58152763', 3327 + 'javelin-behavior-differential-diff-radios' => '58152763', 3328 + 'javelin-behavior-differential-dropdown-menus' => '58152763', 3329 + 'javelin-behavior-differential-edit-inline-comments' => '58152763', 3330 + 'javelin-behavior-differential-feedback-preview' => '58152763', 3331 + 'javelin-behavior-differential-keyboard-navigation' => '58152763', 3332 + 'javelin-behavior-differential-populate' => '58152763', 3333 + 'javelin-behavior-differential-show-more' => '58152763', 3334 3334 'javelin-behavior-diffusion-commit-graph' => '5e68be89', 3335 3335 'javelin-behavior-diffusion-pull-lastmodified' => '5e68be89', 3336 3336 'javelin-behavior-maniphest-batch-selector' => '7707de41', ··· 3340 3340 'javelin-behavior-maniphest-transaction-preview' => '7707de41', 3341 3341 'javelin-behavior-phabricator-autofocus' => '805a58d7', 3342 3342 'javelin-behavior-phabricator-keyboard-shortcuts' => '805a58d7', 3343 - 'javelin-behavior-phabricator-object-selector' => '8136e4a6', 3343 + 'javelin-behavior-phabricator-object-selector' => '58152763', 3344 3344 'javelin-behavior-phabricator-oncopy' => '805a58d7', 3345 3345 'javelin-behavior-phabricator-tooltips' => '805a58d7', 3346 3346 'javelin-behavior-phabricator-watch-anchor' => '805a58d7', 3347 3347 'javelin-behavior-refresh-csrf' => '805a58d7', 3348 - 'javelin-behavior-repository-crossreference' => '8136e4a6', 3348 + 'javelin-behavior-repository-crossreference' => '58152763', 3349 3349 'javelin-behavior-workflow' => '805a58d7', 3350 3350 'javelin-dom' => 'c50bbf3a', 3351 3351 'javelin-event' => 'c50bbf3a', ··· 3367 3367 'maniphest-task-summary-css' => '7839ae2d', 3368 3368 'maniphest-transaction-detail-css' => '7839ae2d', 3369 3369 'phabricator-app-buttons-css' => '10a01616', 3370 - 'phabricator-content-source-view-css' => '2ba14b3d', 3370 + 'phabricator-content-source-view-css' => '7d861806', 3371 3371 'phabricator-core-buttons-css' => '10a01616', 3372 3372 'phabricator-core-css' => '10a01616', 3373 3373 'phabricator-directory-css' => '10a01616', 3374 - 'phabricator-drag-and-drop-file-upload' => '8136e4a6', 3374 + 'phabricator-drag-and-drop-file-upload' => '58152763', 3375 3375 'phabricator-dropdown-menu' => '805a58d7', 3376 3376 'phabricator-flag-css' => '10a01616', 3377 3377 'phabricator-jump-nav' => '10a01616', 3378 3378 'phabricator-keyboard-shortcut' => '805a58d7', 3379 3379 'phabricator-keyboard-shortcut-manager' => '805a58d7', 3380 3380 'phabricator-menu-item' => '805a58d7', 3381 - 'phabricator-object-selector-css' => '2ba14b3d', 3381 + 'phabricator-object-selector-css' => '7d861806', 3382 3382 'phabricator-paste-file-upload' => '805a58d7', 3383 3383 'phabricator-prefab' => '805a58d7', 3384 3384 'phabricator-project-tag-css' => '7839ae2d', 3385 3385 'phabricator-remarkup-css' => '10a01616', 3386 - 'phabricator-shaped-request' => '8136e4a6', 3386 + 'phabricator-shaped-request' => '58152763', 3387 3387 'phabricator-standard-page-view' => '10a01616', 3388 3388 'phabricator-tooltip' => '805a58d7', 3389 3389 'phabricator-transaction-view-css' => '10a01616',
+4 -2
src/__phutil_library_map__.php
··· 226 226 'DifferentialChangesetParser' => 'applications/differential/parser/DifferentialChangesetParser.php', 227 227 'DifferentialChangesetParserTestCase' => 'applications/differential/parser/__tests__/DifferentialChangesetParserTestCase.php', 228 228 'DifferentialChangesetViewController' => 'applications/differential/controller/DifferentialChangesetViewController.php', 229 + 'DifferentialCodeWidthSensitiveView' => 'applications/differential/view/DifferentialCodeWidthSensitiveView.php', 229 230 'DifferentialComment' => 'applications/differential/storage/DifferentialComment.php', 230 231 'DifferentialCommentEditor' => 'applications/differential/editor/DifferentialCommentEditor.php', 231 232 'DifferentialCommentMail' => 'applications/differential/mail/DifferentialCommentMail.php', ··· 1473 1474 'DifferentialChangeSetTestCase' => 'PhabricatorTestCase', 1474 1475 'DifferentialChangeset' => 'DifferentialDAO', 1475 1476 'DifferentialChangesetDetailView' => 'AphrontView', 1476 - 'DifferentialChangesetListView' => 'AphrontView', 1477 + 'DifferentialChangesetListView' => 'DifferentialCodeWidthSensitiveView', 1477 1478 'DifferentialChangesetParserTestCase' => 'ArcanistPhutilTestCase', 1478 1479 'DifferentialChangesetViewController' => 'DifferentialController', 1480 + 'DifferentialCodeWidthSensitiveView' => 'AphrontView', 1479 1481 'DifferentialComment' => 1480 1482 array( 1481 1483 0 => 'DifferentialDAO', ··· 1526 1528 'DifferentialManiphestTasksFieldSpecification' => 'DifferentialFieldSpecification', 1527 1529 'DifferentialNewDiffMail' => 'DifferentialReviewRequestMail', 1528 1530 'DifferentialPathFieldSpecification' => 'DifferentialFieldSpecification', 1529 - 'DifferentialPrimaryPaneView' => 'AphrontView', 1531 + 'DifferentialPrimaryPaneView' => 'DifferentialCodeWidthSensitiveView', 1530 1532 'DifferentialReplyHandler' => 'PhabricatorMailReplyHandler', 1531 1533 'DifferentialResultsTableView' => 'AphrontView', 1532 1534 'DifferentialRevertPlanFieldSpecification' => 'DifferentialFieldSpecification',
+11 -9
src/applications/differential/controller/DifferentialChangesetViewController.php
··· 250 250 $detail->appendChild($output); 251 251 $detail->setVsChangesetID($left_source); 252 252 253 - $output = 254 - id(new DifferentialPrimaryPaneView()) 255 - ->setLineWidthFromChangesets(array($changeset)) 256 - ->appendChild( 257 - '<div class="differential-review-stage" '. 258 - 'id="differential-review-stage">'. 259 - $detail->render(). 260 - '</div>'); 253 + $panel = id(new DifferentialPrimaryPaneView()) 254 + ->setLineWidthFromChangesets(array($changeset)); 255 + 256 + $panel->appendChild(phutil_render_tag('div', 257 + array( 258 + 'class' => 'differential-review-stage', 259 + 'id' => 'differential-review-stage', 260 + 'style' => "max-width: {$panel->calculateSideBySideWidth()}px;" 261 + ), $detail->render()) 262 + ); 261 263 262 264 return $this->buildStandardPageResponse( 263 265 array( 264 - $output 266 + $panel 265 267 ), 266 268 array( 267 269 'title' => 'Changeset View',
+1
src/applications/differential/controller/DifferentialDiffViewController.php
··· 116 116 $details = id(new DifferentialChangesetListView()) 117 117 ->setChangesets($changesets) 118 118 ->setVisibleChangesets($changesets) 119 + ->setLineWidthFromChangesets($changesets) 119 120 ->setRenderingReferences($refs) 120 121 ->setStandaloneURI('/differential/changeset/') 121 122 ->setUser($request->getUser());
+1
src/applications/differential/controller/DifferentialRevisionViewController.php
··· 285 285 } 286 286 287 287 $changeset_view = new DifferentialChangesetListView(); 288 + $changeset_view->setLineWidthFromChangesets($changesets); 288 289 $changeset_view->setChangesets($changesets); 289 290 $changeset_view->setVisibleChangesets($visible_changesets); 290 291
+1 -1
src/applications/differential/parser/DifferentialChangesetParser.php
··· 1521 1521 implode(' &bull; ', $contents). 1522 1522 '</td>'. 1523 1523 '<th class="show-context-line">'.$context_line.'</td>'. 1524 - '<td colspan="2" class="show-context">'.$context.'</td>'); 1524 + '<td colspan="3" class="show-context">'.$context.'</td>'); 1525 1525 1526 1526 $html[] = $container; 1527 1527
+6 -16
src/applications/differential/view/DifferentialAddCommentView.php
··· 102 102 $form = new AphrontFormView(); 103 103 $form 104 104 ->setWorkflow(true) 105 + ->setFlexible(true) 105 106 ->setUser($this->user) 106 107 ->setAction($this->actionURI) 107 108 ->addHiddenInput('revision_id', $revision->getID()) ··· 164 165 165 166 $diff = $revision->loadActiveDiff(); 166 167 $warnings = mpull($this->auxFields, 'renderWarningBoxForRevisionAccept'); 167 - $lint_warning = null; 168 - $unit_warning = null; 169 168 170 169 Javelin::initBehavior( 171 170 'differential-accept-with-errors', ··· 192 191 'inline' => 'inline-comment-preview', 193 192 )); 194 193 195 - $panel_view = new AphrontPanelView(); 196 - $panel_view->appendChild($form); 197 194 $warning_container = '<div id="warnings">'; 198 195 foreach ($warnings as $warning) { 199 196 if ($warning) { ··· 201 198 } 202 199 } 203 200 $warning_container .= '</div>'; 204 - $panel_view->appendChild($warning_container); 205 - if ($lint_warning) { 206 - $panel_view->appendChild($lint_warning); 207 - } 208 - if ($unit_warning) { 209 - $panel_view->appendChild($unit_warning); 210 - } 211 201 212 - $panel_view->setHeader($is_serious ? 'Add Comment' : 'Leap Into Action'); 213 - 214 - $panel_view->addClass('aphront-panel-accent'); 215 - $panel_view->addClass('aphront-panel-flush'); 202 + $header = id(new PhabricatorHeaderView()) 203 + ->setHeader($is_serious ? 'Add Comment' : 'Leap Into Action'); 216 204 217 205 return 218 206 id(new PhabricatorAnchorView()) ··· 220 208 ->setNavigationMarker(true) 221 209 ->render(). 222 210 '<div class="differential-add-comment-panel">'. 223 - $panel_view->render(). 211 + $header->render(). 212 + $form->render(). 213 + $warning_container. 224 214 '<div class="aphront-panel-preview aphront-panel-flush">'. 225 215 '<div id="comment-preview">'. 226 216 '<span class="aphront-panel-preview-loading-text">'.
+3 -1
src/applications/differential/view/DifferentialChangesetListView.php
··· 16 16 * limitations under the License. 17 17 */ 18 18 19 - final class DifferentialChangesetListView extends AphrontView { 19 + final class DifferentialChangesetListView 20 + extends DifferentialCodeWidthSensitiveView { 20 21 21 22 private $changesets = array(); 22 23 private $visibleChangesets = array(); ··· 209 210 array( 210 211 'class' => 'differential-review-stage', 211 212 'id' => 'differential-review-stage', 213 + 'style' => "max-width: {$this->calculateSideBySideWidth()}px; ", 212 214 ), 213 215 implode("\n", $output)); 214 216 }
+55
src/applications/differential/view/DifferentialCodeWidthSensitiveView.php
··· 1 + <?php 2 + 3 + /* 4 + * Copyright 2012 Facebook, Inc. 5 + * 6 + * Licensed under the Apache License, Version 2.0 (the "License"); 7 + * you may not use this file except in compliance with the License. 8 + * You may obtain a copy of the License at 9 + * 10 + * http://www.apache.org/licenses/LICENSE-2.0 11 + * 12 + * Unless required by applicable law or agreed to in writing, software 13 + * distributed under the License is distributed on an "AS IS" BASIS, 14 + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 15 + * See the License for the specific language governing permissions and 16 + * limitations under the License. 17 + */ 18 + 19 + abstract class DifferentialCodeWidthSensitiveView extends AphrontView { 20 + 21 + private $lineWidth = 80; 22 + 23 + private function setLineWidth($width) { 24 + $this->lineWidth = $width; 25 + return $this; 26 + } 27 + 28 + public function getLineWidth() { 29 + return $this->lineWidth; 30 + } 31 + 32 + public function setLineWidthFromChangesets(array $changesets) { 33 + assert_instances_of($changesets, 'DifferentialChangeset'); 34 + if (empty($changesets)) { 35 + return $this; 36 + } 37 + 38 + $max = 1; 39 + foreach ($changesets as $changeset) { 40 + $max = max($max, $changeset->getWordWrapWidth()); 41 + } 42 + $this->setLineWidth($max); 43 + 44 + return $this; 45 + } 46 + 47 + public function calculateSideBySideWidth() { 48 + // Width of the constant-width elements (like line numbers, padding, 49 + // and borders). 50 + $const = 148; 51 + $width = ceil(((1162 - $const) / 80) * $this->getLineWidth()) + $const; 52 + return max(1162, $width); 53 + } 54 + 55 + }
+3 -30
src/applications/differential/view/DifferentialPrimaryPaneView.php
··· 16 16 * limitations under the License. 17 17 */ 18 18 19 - final class DifferentialPrimaryPaneView extends AphrontView { 19 + final class DifferentialPrimaryPaneView 20 + extends DifferentialCodeWidthSensitiveView { 20 21 21 - private $lineWidth = 80; 22 22 private $id; 23 - 24 - public function setLineWidth($width) { 25 - $this->lineWidth = $width; 26 - return $this; 27 - } 28 23 29 24 public function setID($id) { 30 25 $this->id = $id; 31 26 return $this; 32 27 } 33 28 34 - public function setLineWidthFromChangesets(array $changesets) { 35 - assert_instances_of($changesets, 'DifferentialChangeset'); 36 - if (empty($changesets)) { 37 - return $this; 38 - } 39 - 40 - $max = 1; 41 - foreach ($changesets as $changeset) { 42 - $max = max($max, $changeset->getWordWrapWidth()); 43 - } 44 - $this->setLineWidth($max); 45 - 46 - return $this; 47 - } 48 - 49 29 public function render() { 50 30 51 31 // This is chosen somewhat arbitrarily so the math works out correctly ··· 53 33 // need some tweaking, but when lineWidth = 80, the computed pixel width 54 34 // should be 1162px or something along those lines. 55 35 56 - // Width of the constant-width elements (like line numbers, padding, 57 - // and borders). 58 - $const = 148; 59 - $width = ceil(((1162 - $const) / 80) * $this->lineWidth) + $const; 60 - $width = max(1162, $width); 61 - 62 36 // Override the 'td' width rule with a more specific, inline style tag. 63 37 // TODO: move this to <head> somehow. 64 - $td_width = ceil((88 / 80) * $this->lineWidth); 38 + $td_width = ceil((88 / 80) * $this->getLineWidth()); 65 39 $style_tag = phutil_render_tag( 66 40 'style', 67 41 array( ··· 73 47 'div', 74 48 array( 75 49 'class' => 'differential-primary-pane', 76 - 'style' => "max-width: {$width}px", 77 50 'id' => $this->id, 78 51 ), 79 52 $style_tag.$this->renderChildren());
+10
webroot/rsrc/css/application/differential/changeset-view.css
··· 2 2 * @provides differential-changeset-view-css 3 3 */ 4 4 5 + .differential-review-stage { 6 + margin: 0 2em 0 2em; 7 + 8 + /** 9 + * This is potentially overridden by a 'style' attribute which selects a 10 + * different width based on the maximum character width of the diff. 11 + */ 12 + max-width: 1162px; 13 + } 14 + 5 15 .differential-changeset { 6 16 z-index: 2; 7 17 position: relative;
+1 -9
webroot/rsrc/css/application/differential/core.css
··· 3 3 */ 4 4 5 5 .differential-primary-pane { 6 - margin: 0 0 0 2em; 7 6 padding-bottom: 2em; 8 - 9 - /** 10 - * This is potentially overridden by a 'style' attribute which selects a 11 - * different width based on the maximum character width of the diff. 12 - */ 13 - max-width: 1162px; 14 7 } 15 8 16 9 .differential-panel { 17 - margin: 25px 0 0 0; 18 - max-width: 1120px; 10 + margin: 25px 2em 0 2em; 19 11 border: 1px solid #666622; 20 12 background: #efefdf; 21 13 padding: 15px 20px;
+1 -7
webroot/rsrc/css/application/differential/revision-comment.css
··· 3 3 */ 4 4 5 5 .differential-comment-list { 6 - max-width: 1162px; 7 - } 8 - 9 - .differential-add-comment-panel { 10 - max-width: 1162px; 6 + margin: 0 2em 0 2em; 11 7 } 12 8 13 9 /* Spooky haunted panel which floats on the bottom of the screen. ··· 26 22 z-index: 8; 27 23 overflow: auto; 28 24 max-height: 375px; 29 - max-width: none; 30 25 31 26 box-shadow: 0 0 4px #000; 32 27 -webkit-box-shadow: 0 0 4px #000; 33 28 -moz-box-shadow: 0 0 4px #000; 34 - 35 29 } 36 30 37 31 .differential-haunt-mode-2 .differential-add-comment-panel {