recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix mask positioning and use mask classes in lightbox

Summary: See D3795 / D3797. Also made the mask darker.

Test Plan: Mask now sizes properly on window resize in all browsers / mask uses.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D3798

epriestley e0cc277d 1a8232f4

+58 -67
+49 -50
src/__celerity_resource_map__.php
··· 579 579 ), 580 580 'aphront-dialog-view-css' => 581 581 array( 582 - 'uri' => '/res/eedc489d/rsrc/css/aphront/dialog-view.css', 582 + 'uri' => '/res/539f1755/rsrc/css/aphront/dialog-view.css', 583 583 'type' => 'css', 584 584 'requires' => 585 585 array( ··· 1385 1385 ), 1386 1386 'javelin-behavior-lightbox-attachments' => 1387 1387 array( 1388 - 'uri' => '/res/bf398927/rsrc/js/application/core/behavior-lightbox-attachments.js', 1388 + 'uri' => '/res/0cfebd8a/rsrc/js/application/core/behavior-lightbox-attachments.js', 1389 1389 'type' => 'js', 1390 1390 'requires' => 1391 1391 array( ··· 1932 1932 ), 1933 1933 'javelin-mask' => 1934 1934 array( 1935 - 'uri' => '/res/03ef78b8/rsrc/js/javelin/lib/Mask.js', 1935 + 'uri' => '/res/d2a35fff/rsrc/js/javelin/lib/Mask.js', 1936 1936 'type' => 'js', 1937 1937 'requires' => 1938 1938 array( 1939 1939 0 => 'javelin-install', 1940 - 1 => 'javelin-vector', 1941 - 2 => 'javelin-dom', 1940 + 1 => 'javelin-dom', 1942 1941 ), 1943 1942 'disk' => '/rsrc/js/javelin/lib/Mask.js', 1944 1943 ), ··· 2238 2237 ), 2239 2238 'lightbox-attachment-css' => 2240 2239 array( 2241 - 'uri' => '/res/398fdb62/rsrc/css/aphront/lightbox-attachment.css', 2240 + 'uri' => '/res/136d479b/rsrc/css/aphront/lightbox-attachment.css', 2242 2241 'type' => 'css', 2243 2242 'requires' => 2244 2243 array( ··· 3071 3070 ), array( 3072 3071 'packages' => 3073 3072 array( 3074 - '8eb36c35' => 3073 + '4322f368' => 3075 3074 array( 3076 3075 'name' => 'core.pkg.css', 3077 3076 'symbols' => ··· 3100 3099 21 => 'phabricator-flag-css', 3101 3100 22 => 'aphront-error-view-css', 3102 3101 ), 3103 - 'uri' => '/res/pkg/8eb36c35/core.pkg.css', 3102 + 'uri' => '/res/pkg/4322f368/core.pkg.css', 3104 3103 'type' => 'css', 3105 3104 ), 3106 - 'f3d6fc91' => 3105 + 'f5ccc73b' => 3107 3106 array( 3108 3107 'name' => 'core.pkg.js', 3109 3108 'symbols' => ··· 3126 3125 15 => 'javelin-behavior-phabricator-tooltips', 3127 3126 16 => 'phabricator-prefab', 3128 3127 ), 3129 - 'uri' => '/res/pkg/f3d6fc91/core.pkg.js', 3128 + 'uri' => '/res/pkg/f5ccc73b/core.pkg.js', 3130 3129 'type' => 'js', 3131 3130 ), 3132 3131 '2ba14b3d' => ··· 3267 3266 'reverse' => 3268 3267 array( 3269 3268 'aphront-attached-file-view-css' => '7839ae2d', 3270 - 'aphront-crumbs-view-css' => '8eb36c35', 3271 - 'aphront-dialog-view-css' => '8eb36c35', 3272 - 'aphront-error-view-css' => '8eb36c35', 3273 - 'aphront-form-view-css' => '8eb36c35', 3269 + 'aphront-crumbs-view-css' => '4322f368', 3270 + 'aphront-dialog-view-css' => '4322f368', 3271 + 'aphront-error-view-css' => '4322f368', 3272 + 'aphront-form-view-css' => '4322f368', 3274 3273 'aphront-headsup-action-list-view-css' => '2ba14b3d', 3275 - 'aphront-headsup-view-css' => '8eb36c35', 3276 - 'aphront-list-filter-view-css' => '8eb36c35', 3277 - 'aphront-pager-view-css' => '8eb36c35', 3278 - 'aphront-panel-view-css' => '8eb36c35', 3279 - 'aphront-side-nav-view-css' => '8eb36c35', 3280 - 'aphront-table-view-css' => '8eb36c35', 3281 - 'aphront-tokenizer-control-css' => '8eb36c35', 3282 - 'aphront-tooltip-css' => '8eb36c35', 3283 - 'aphront-typeahead-control-css' => '8eb36c35', 3274 + 'aphront-headsup-view-css' => '4322f368', 3275 + 'aphront-list-filter-view-css' => '4322f368', 3276 + 'aphront-pager-view-css' => '4322f368', 3277 + 'aphront-panel-view-css' => '4322f368', 3278 + 'aphront-side-nav-view-css' => '4322f368', 3279 + 'aphront-table-view-css' => '4322f368', 3280 + 'aphront-tokenizer-control-css' => '4322f368', 3281 + 'aphront-tooltip-css' => '4322f368', 3282 + 'aphront-typeahead-control-css' => '4322f368', 3284 3283 'differential-changeset-view-css' => '2ba14b3d', 3285 3284 'differential-core-view-css' => '2ba14b3d', 3286 3285 'differential-inline-comment-editor' => '8136e4a6', ··· 3299 3298 'javelin-behavior-aphront-basic-tokenizer' => 'dd024ca1', 3300 3299 'javelin-behavior-aphront-drag-and-drop' => '8136e4a6', 3301 3300 'javelin-behavior-aphront-drag-and-drop-textarea' => '8136e4a6', 3302 - 'javelin-behavior-aphront-form-disable-on-submit' => 'f3d6fc91', 3301 + 'javelin-behavior-aphront-form-disable-on-submit' => 'f5ccc73b', 3303 3302 'javelin-behavior-audit-preview' => '5e68be89', 3304 3303 'javelin-behavior-differential-accept-with-errors' => '8136e4a6', 3305 3304 'javelin-behavior-differential-add-reviewers-and-ccs' => '8136e4a6', ··· 3318 3317 'javelin-behavior-maniphest-transaction-controls' => '7707de41', 3319 3318 'javelin-behavior-maniphest-transaction-expand' => '7707de41', 3320 3319 'javelin-behavior-maniphest-transaction-preview' => '7707de41', 3321 - 'javelin-behavior-phabricator-autofocus' => 'f3d6fc91', 3322 - 'javelin-behavior-phabricator-keyboard-shortcuts' => 'f3d6fc91', 3320 + 'javelin-behavior-phabricator-autofocus' => 'f5ccc73b', 3321 + 'javelin-behavior-phabricator-keyboard-shortcuts' => 'f5ccc73b', 3323 3322 'javelin-behavior-phabricator-object-selector' => '8136e4a6', 3324 - 'javelin-behavior-phabricator-oncopy' => 'f3d6fc91', 3325 - 'javelin-behavior-phabricator-tooltips' => 'f3d6fc91', 3326 - 'javelin-behavior-phabricator-watch-anchor' => 'f3d6fc91', 3327 - 'javelin-behavior-refresh-csrf' => 'f3d6fc91', 3323 + 'javelin-behavior-phabricator-oncopy' => 'f5ccc73b', 3324 + 'javelin-behavior-phabricator-tooltips' => 'f5ccc73b', 3325 + 'javelin-behavior-phabricator-watch-anchor' => 'f5ccc73b', 3326 + 'javelin-behavior-refresh-csrf' => 'f5ccc73b', 3328 3327 'javelin-behavior-repository-crossreference' => '8136e4a6', 3329 - 'javelin-behavior-workflow' => 'f3d6fc91', 3328 + 'javelin-behavior-workflow' => 'f5ccc73b', 3330 3329 'javelin-dom' => 'c50bbf3a', 3331 3330 'javelin-event' => 'c50bbf3a', 3332 3331 'javelin-install' => 'c50bbf3a', 3333 3332 'javelin-json' => 'c50bbf3a', 3334 - 'javelin-mask' => 'f3d6fc91', 3333 + 'javelin-mask' => 'f5ccc73b', 3335 3334 'javelin-request' => 'c50bbf3a', 3336 3335 'javelin-stratcom' => 'c50bbf3a', 3337 3336 'javelin-tokenizer' => 'dd024ca1', ··· 3343 3342 'javelin-uri' => 'c50bbf3a', 3344 3343 'javelin-util' => 'c50bbf3a', 3345 3344 'javelin-vector' => 'c50bbf3a', 3346 - 'javelin-workflow' => 'f3d6fc91', 3345 + 'javelin-workflow' => 'f5ccc73b', 3347 3346 'maniphest-task-summary-css' => '7839ae2d', 3348 3347 'maniphest-transaction-detail-css' => '7839ae2d', 3349 - 'phabricator-app-buttons-css' => '8eb36c35', 3348 + 'phabricator-app-buttons-css' => '4322f368', 3350 3349 'phabricator-content-source-view-css' => '2ba14b3d', 3351 - 'phabricator-core-buttons-css' => '8eb36c35', 3352 - 'phabricator-core-css' => '8eb36c35', 3353 - 'phabricator-directory-css' => '8eb36c35', 3350 + 'phabricator-core-buttons-css' => '4322f368', 3351 + 'phabricator-core-css' => '4322f368', 3352 + 'phabricator-directory-css' => '4322f368', 3354 3353 'phabricator-drag-and-drop-file-upload' => '8136e4a6', 3355 - 'phabricator-dropdown-menu' => 'f3d6fc91', 3356 - 'phabricator-flag-css' => '8eb36c35', 3357 - 'phabricator-jump-nav' => '8eb36c35', 3358 - 'phabricator-keyboard-shortcut' => 'f3d6fc91', 3359 - 'phabricator-keyboard-shortcut-manager' => 'f3d6fc91', 3360 - 'phabricator-menu-item' => 'f3d6fc91', 3354 + 'phabricator-dropdown-menu' => 'f5ccc73b', 3355 + 'phabricator-flag-css' => '4322f368', 3356 + 'phabricator-jump-nav' => '4322f368', 3357 + 'phabricator-keyboard-shortcut' => 'f5ccc73b', 3358 + 'phabricator-keyboard-shortcut-manager' => 'f5ccc73b', 3359 + 'phabricator-menu-item' => 'f5ccc73b', 3361 3360 'phabricator-object-selector-css' => '2ba14b3d', 3362 - 'phabricator-paste-file-upload' => 'f3d6fc91', 3363 - 'phabricator-prefab' => 'f3d6fc91', 3361 + 'phabricator-paste-file-upload' => 'f5ccc73b', 3362 + 'phabricator-prefab' => 'f5ccc73b', 3364 3363 'phabricator-project-tag-css' => '7839ae2d', 3365 - 'phabricator-remarkup-css' => '8eb36c35', 3364 + 'phabricator-remarkup-css' => '4322f368', 3366 3365 'phabricator-shaped-request' => '8136e4a6', 3367 - 'phabricator-standard-page-view' => '8eb36c35', 3368 - 'phabricator-tooltip' => 'f3d6fc91', 3369 - 'phabricator-transaction-view-css' => '8eb36c35', 3370 - 'syntax-highlighting-css' => '8eb36c35', 3366 + 'phabricator-standard-page-view' => '4322f368', 3367 + 'phabricator-tooltip' => 'f5ccc73b', 3368 + 'phabricator-transaction-view-css' => '4322f368', 3369 + 'syntax-highlighting-css' => '4322f368', 3371 3370 ), 3372 3371 ));
+7 -7
webroot/rsrc/css/aphront/dialog-view.css
··· 48 48 49 49 .jx-mask { 50 50 opacity: .37; 51 - -ms-filter: "progid:DXImageTransform.Microsoft.Alpha(Opacity=37)"; 52 - filter: alpha(opacity=37); 53 51 background: #222; 54 - position: absolute; 55 - z-index: 5; 52 + position: fixed; 53 + z-index: 10; 56 54 top: 0; 57 55 left: 0; 58 56 right: 0; 59 57 bottom: 0; 60 - width: 100%; 61 - height: 100%; 62 - min-height: 100%; 58 + } 59 + 60 + .jx-dark-mask { 61 + background: #000000; 62 + opacity: 0.9; 63 63 } 64 64 65 65 .aphront-exception-dialog {
+1 -9
webroot/rsrc/css/aphront/lightbox-attachment.css
··· 7 7 overflow-y: hidden; 8 8 } 9 9 10 - .lightbox-attached .jx-mask { 11 - opacity: 0.76; 12 - -ms-filter: "progid:DXImageTransform.Microsoft.Alpha(Opacity=76)"; 13 - filter: alpha(opacity=76); 14 - /* jx-mask behavior sets this dynamically so !important to win */ 15 - width: 100% !important; 16 - } 17 - 18 10 .lightbox-attachment { 19 11 position: fixed; 20 12 top: 44px; 21 13 left: 0; 22 - z-index: 6; 14 + z-index: 12; 23 15 width: 100%; 24 16 } 25 17
+1 -1
webroot/rsrc/js/application/core/behavior-lightbox-attachments.js
··· 171 171 ); 172 172 JX.DOM.appendContent(lightbox, statusHTML); 173 173 JX.DOM.alterClass(document.body, 'lightbox-attached', true); 174 - JX.Mask.show(); 174 + JX.Mask.show('jx-dark-mask'); 175 175 document.body.appendChild(lightbox); 176 176 img.src = img_uri; 177 177 }