@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove "effector" from HeraldAdapter
Summary:
Ref T7731.
- This does nothing.
- I don't know what this was supposed to do.
- It didn't do anything when it was introduced in rP084c79d85a in 2011, either.
iiam
Test Plan:
- `grep`
- ???
Reviewers: btrahan
Reviewed By: btrahan
Subscribers: epriestley
Maniphest Tasks: T7731
Differential Revision: https://secure.phabricator.com/D12267
-24
-10
src/applications/herald/engine/HeraldEffect.php
-10
src/applications/herald/engine/HeraldEffect.php
···
8
8
9
9
private $ruleID;
10
10
private $rulePHID;
11
-
private $effector;
12
11
13
12
private $reason;
14
13
···
55
54
56
55
public function getRulePHID() {
57
56
return $this->rulePHID;
58
-
}
59
-
60
-
public function setEffector($effector) {
61
-
$this->effector = $effector;
62
-
return $this;
63
-
}
64
-
65
-
public function getEffector() {
66
-
return $this->effector;
67
57
}
68
58
69
59
public function setReason($reason) {
-14
src/applications/herald/storage/transcript/HeraldApplyTranscript.php
-14
src/applications/herald/storage/transcript/HeraldApplyTranscript.php
···
4
4
5
5
private $action;
6
6
private $target;
7
-
8
7
private $ruleID;
9
-
private $effector;
10
-
11
8
private $reason;
12
-
13
9
private $applied;
14
10
private $appliedReason;
15
11
···
21
17
$this->setAction($effect->getAction());
22
18
$this->setTarget($effect->getTarget());
23
19
$this->setRuleID($effect->getRuleID());
24
-
$this->setEffector($effect->getEffector());
25
20
$this->setReason($effect->getReason());
26
21
$this->setApplied($applied);
27
22
$this->setAppliedReason($reason);
···
52
47
53
48
public function getRuleID() {
54
49
return $this->ruleID;
55
-
}
56
-
57
-
public function setEffector($effector) {
58
-
$this->effector = $effector;
59
-
return $this;
60
-
}
61
-
62
-
public function getEffector() {
63
-
return $this->effector;
64
50
}
65
51
66
52
public function setReason($reason) {