@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix a Calendar import issue where we looked up attendees by object instead of name
Summary:
Ref T11801. This issue led to the stack trace in T11801#199042.
It wasn't obvious that this was wrong because the recover-on-duplicate-key code made it work correctly.
Test Plan: Imported an event with external attendees with no warnings in the log.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T11801
Differential Revision: https://secure.phabricator.com/D16804
+1
-1
+1
-1
src/applications/calendar/import/PhabricatorCalendarImportEngine.php
+1
-1
src/applications/calendar/import/PhabricatorCalendarImportEngine.php
···
259
259
if ($attendee_names) {
260
260
$external_invitees = id(new PhabricatorCalendarExternalInviteeQuery())
261
261
->setViewer($viewer)
262
-
->withNames($attendee_names)
262
+
->withNames(array_keys($attendee_names))
263
263
->execute();
264
264
$external_invitees = mpull($external_invitees, null, 'getName');
265
265