recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix a bug where Phortune accounts created via "Create Account" would not have the viewer added as a member

Summary:
Ref T12451. When you explicitly created a second or third account or whatever, you wouldn't be added as a member.

(The editor sees that you're "already a member", so it doesn't add you.)

Test Plan:
- Go to `/phortune/`.
- Click "Switch Accounts".
- Click "Create Account".
- Create an account.
- Before patch: unable to view it since you don't get added as a member.
- After patch: account created with you as member.
- Also created an accont with multiple members.
- Tried to create an account with no members.
- Tried to create an account with just someone else as a member.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12451

Differential Revision: https://secure.phabricator.com/D17690

epriestley e1a8b5d3 7274e485

+2 -4
+2 -4
src/applications/phortune/storage/PhortuneAccount.php
··· 16 16 private $memberPHIDs = self::ATTACHABLE; 17 17 18 18 public static function initializeNewAccount(PhabricatorUser $actor) { 19 - $account = id(new PhortuneAccount()); 20 - $account->memberPHIDs = array($actor->getPHID() => $actor->getPHID()); 21 - 22 - return $account; 19 + return id(new self()) 20 + ->attachMemberPHIDs(array()); 23 21 } 24 22 25 23 public static function createNewAccount(