recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix one more "Reviewers" wire format issue

Summary: Fixes T11010. This also needs to be inflated until we fix the whole client/server responsibility issue here.

Test Plan:
- Created a revision while observing error log, no error.
- Disabled "allow self accept", tried to make myself a reviewer, got rejected with an error message.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11010

Differential Revision: https://secure.phabricator.com/D15966

epriestley e1ad312f 627b95bf

+1
+1
src/applications/differential/customfield/DifferentialReviewersField.php
··· 242 242 $config_self_accept_key = 'differential.allow-self-accept'; 243 243 $allow_self_accept = PhabricatorEnv::getEnvConfig($config_self_accept_key); 244 244 245 + $value = $this->inflateReviewers($value); 245 246 foreach ($value as $spec) { 246 247 $phid = $spec['phid']; 247 248