@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Improve Dark Mode for Dependency Graph lines
Summary:
Set 50% transparency on hardcoded white stroke style color (and default filling color) so things look less horrible in Dark Mode and still look fine in Default Mode.
Refs T15056
Test Plan:
* Go to http://phorge.localhost/settings/panel/display/ and set `Accessibility` to `Dark Mode (Experimental)`
* Go to a task with parent tasks and subtasks, look at the vertical lines in the Task Graph box.
* Probably test the same in Diffusion or Differential but I am too lazy.
Reviewers: O1 Blessed Committers, mainframe98
Reviewed By: O1 Blessed Committers, mainframe98
Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Maniphest Tasks: T15056
Differential Revision: https://we.phorge.it/D26390
+15
-12
+8
-8
resources/celerity/map.php
+8
-8
resources/celerity/map.php
···
15
15
'differential.pkg.css' => '77189aae',
16
16
'differential.pkg.js' => '46fcb3af',
17
17
'diffusion.pkg.css' => '91e57dc1',
18
-
'diffusion.pkg.js' => '78c9885d',
18
+
'diffusion.pkg.js' => 'd06aa1f7',
19
19
'maniphest.pkg.css' => '31ad4266',
20
20
'maniphest.pkg.js' => 'c9308721',
21
21
'rsrc/audio/basic/alert.mp3' => '17889334',
···
344
344
'rsrc/js/application/diffusion/ExternalEditorLinkEngine.js' => '48a8641f',
345
345
'rsrc/js/application/diffusion/behavior-audit-preview.js' => 'b7b73831',
346
346
'rsrc/js/application/diffusion/behavior-commit-branches.js' => '4b671572',
347
-
'rsrc/js/application/diffusion/behavior-commit-graph.js' => 'ac10c917',
347
+
'rsrc/js/application/diffusion/behavior-commit-graph.js' => '56d8091e',
348
348
'rsrc/js/application/diffusion/behavior-locate-file.js' => '4c77f259',
349
349
'rsrc/js/application/diffusion/behavior-pull-lastmodified.js' => 'c715c123',
350
350
'rsrc/js/application/doorkeeper/behavior-doorkeeper-tag.js' => '6a85bc5a',
···
569
569
'javelin-behavior-differential-diff-radios' => '925fe8cd',
570
570
'javelin-behavior-differential-populate' => 'b86ef6c2',
571
571
'javelin-behavior-diffusion-commit-branches' => '4b671572',
572
-
'javelin-behavior-diffusion-commit-graph' => 'ac10c917',
572
+
'javelin-behavior-diffusion-commit-graph' => '56d8091e',
573
573
'javelin-behavior-diffusion-locate-file' => '4c77f259',
574
574
'javelin-behavior-diffusion-pull-lastmodified' => 'c715c123',
575
575
'javelin-behavior-document-engine' => '243d6c22',
···
1344
1344
'javelin-install',
1345
1345
'javelin-dom',
1346
1346
),
1347
+
'56d8091e' => array(
1348
+
'javelin-behavior',
1349
+
'javelin-dom',
1350
+
'javelin-stratcom',
1351
+
),
1347
1352
'5793d835' => array(
1348
1353
'javelin-install',
1349
1354
'javelin-util',
···
1793
1798
'multirow-row-manager',
1794
1799
'javelin-json',
1795
1800
'phuix-form-control-view',
1796
-
),
1797
-
'ac10c917' => array(
1798
-
'javelin-behavior',
1799
-
'javelin-dom',
1800
-
'javelin-stratcom',
1801
1801
),
1802
1802
'ac2b1e01' => array(
1803
1803
'javelin-behavior',
+3
src/infrastructure/diff/view/PHUIDiffGraphView.php
+3
src/infrastructure/diff/view/PHUIDiffGraphView.php
+4
-4
webroot/rsrc/js/application/diffusion/behavior-commit-graph.js
+4
-4
webroot/rsrc/js/application/diffusion/behavior-commit-graph.js
···
28
28
// Stroke a line (for lines between commits).
29
29
function lstroke(c) {
30
30
cxt.lineWidth = 3;
31
-
cxt.strokeStyle = '#ffffff';
31
+
cxt.strokeStyle = 'rgb(255 255 255 / 50%)';
32
32
cxt.stroke();
33
33
cxt.lineWidth = 1;
34
34
cxt.strokeStyle = color(c);
···
39
39
function fstroke(c) {
40
40
cxt.lineWidth = 1;
41
41
cxt.fillStyle = color(c);
42
-
cxt.strokeStyle = '#ffffff';
42
+
cxt.strokeStyle = 'rgb(255 255 255 / 50%)';
43
43
cxt.fill();
44
44
cxt.stroke();
45
45
}
···
78
78
// are drawn from 4.5 to 5.5.
79
79
cxt.translate(0.5, 0.5);
80
80
81
-
cxt.strokeStyle = '#ffffff';
82
-
cxt.fillStyle = '#ffffff';
81
+
cxt.strokeStyle = 'rgb(255 255 255 / 50%)';
82
+
cxt.fillStyle = 'rgb(255 255 255 / 50%)';
83
83
84
84
// First, figure out which column this commit appears in. It is marked by
85
85
// "o" (if it has a commit after it) or "^" (if no other commit has it as