@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
[Redesign] Fix 'nodata' display on search results
Summary: Ref T8099, We can just set the no data string on the ObjectList directly.
Test Plan: Run a bum query, see better UI.
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Maniphest Tasks: T8099
Differential Revision: https://secure.phabricator.com/D13087
+3
-8
+3
-8
src/applications/search/query/PhabricatorSearchApplicationSearchEngine.php
+3
-8
src/applications/search/query/PhabricatorSearchApplicationSearchEngine.php
···
240
240
array $handles) {
241
241
242
242
$viewer = $this->requireViewer();
243
+
$list = new PHUIObjectItemListView();
244
+
$list->setNoDataString(pht('No results returned for that query.'));
243
245
244
246
if ($results) {
245
247
$objects = id(new PhabricatorObjectQuery())
···
247
249
->withPHIDs(mpull($results, 'getPHID'))
248
250
->execute();
249
251
250
-
$list = new PHUIObjectItemListView();
251
252
foreach ($results as $phid => $handle) {
252
253
$view = id(new PhabricatorSearchResultView())
253
254
->setHandle($handle)
···
256
257
->render();
257
258
$list->addItem($view);
258
259
}
259
-
260
-
$results = $list;
261
-
} else {
262
-
$results = id(new PHUIInfoView())
263
-
->appendChild(pht('No results returned for that query.'))
264
-
->setSeverity(PHUIInfoView::SEVERITY_NODATA);
265
260
}
266
261
267
-
return $results;
262
+
return $list;
268
263
}
269
264
270
265
private function readOwnerPHIDs(PhabricatorSavedQuery $saved) {