@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Revert "feed.http-hooks" HTTP request construction to use "http_build_query()" so nested "storyData" is handled correctly
Summary:
See <https://discourse.phabricator-community.org/t/storydata-is-blank-in-outgoing-requests-to-the-configured-feed-http-hooks/2366/>.
This behavior was changed by D20049. I think it's generally good that we not accept/encode nested values in a PHP-specific way, but retain `feed.http-hooks` compatibility for now.
Test Plan: {F6190681}
Reviewers: amckinley
Reviewed By: amckinley
Differential Revision: https://secure.phabricator.com/D20114
+5
+5
src/applications/feed/worker/FeedPublisherHTTPWorker.php
+5
src/applications/feed/worker/FeedPublisherHTTPWorker.php
···
26
26
'epoch' => $data->getEpoch(),
27
27
);
28
28
29
+
// NOTE: We're explicitly using "http_build_query()" here because the
30
+
// "storyData" parameter may be a nested object with arbitrary nested
31
+
// sub-objects.
32
+
$post_data = http_build_query($post_data, '', '&');
33
+
29
34
id(new HTTPSFuture($uri, $post_data))
30
35
->setMethod('POST')
31
36
->setTimeout(30)