@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix mobile menu for files in Differential Changesets
Summary: Fixes T11305, Ref T7754. Makes this menu dropdown act like actions and collapse to a fa-bars menu.
Test Plan:
View on mobile, desktop, browser. Click an action, spawn new page.
{F1717953}
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Maniphest Tasks: T7754, T11305
Differential Revision: https://secure.phabricator.com/D16265
+18
-23
+6
-6
resources/celerity/map.php
+6
-6
resources/celerity/map.php
···
10
10
'core.pkg.css' => '4e7e9bde',
11
11
'core.pkg.js' => '13c7e56a',
12
12
'darkconsole.pkg.js' => 'e7393ebb',
13
-
'differential.pkg.css' => '3e81ae60',
13
+
'differential.pkg.css' => '3fb7f532',
14
14
'differential.pkg.js' => '634399e9',
15
15
'diffusion.pkg.css' => '91c5d3a6',
16
16
'diffusion.pkg.js' => '84c8f8fd',
···
57
57
'rsrc/css/application/dashboard/dashboard.css' => 'bc6f2127',
58
58
'rsrc/css/application/diff/inline-comment-summary.css' => '51efda3a',
59
59
'rsrc/css/application/differential/add-comment.css' => 'c47f8c40',
60
-
'rsrc/css/application/differential/changeset-view.css' => '37792573',
60
+
'rsrc/css/application/differential/changeset-view.css' => '9ef7d354',
61
61
'rsrc/css/application/differential/core.css' => '5b7b8ff4',
62
62
'rsrc/css/application/differential/phui-inline-comment.css' => '5953c28e',
63
63
'rsrc/css/application/differential/revision-comment.css' => '14b8565a',
···
555
555
'conpherence-update-css' => 'faf6be09',
556
556
'conpherence-widget-pane-css' => '775eaaba',
557
557
'd3' => 'a11a5ff2',
558
-
'differential-changeset-view-css' => '37792573',
558
+
'differential-changeset-view-css' => '9ef7d354',
559
559
'differential-core-view-css' => '5b7b8ff4',
560
560
'differential-inline-comment-editor' => '64a5550f',
561
561
'differential-revision-add-comment-css' => 'c47f8c40',
···
1143
1143
'javelin-dom',
1144
1144
'javelin-workflow',
1145
1145
),
1146
-
37792573 => array(
1147
-
'phui-inline-comment-view-css',
1148
-
),
1149
1146
'3ab51e2c' => array(
1150
1147
'javelin-behavior',
1151
1148
'javelin-behavior-device',
···
1677
1674
'phuix-action-view',
1678
1675
'phabricator-phtize',
1679
1676
'changeset-view-manager',
1677
+
),
1678
+
'9ef7d354' => array(
1679
+
'phui-inline-comment-view-css',
1680
1680
),
1681
1681
'9f36c42d' => array(
1682
1682
'javelin-behavior',
+9
-11
src/applications/differential/view/DifferentialChangesetListView.php
+9
-11
src/applications/differential/view/DifferentialChangesetListView.php
···
342
342
}
343
343
344
344
$meta['containerID'] = $detail->getID();
345
-
$caret = phutil_tag('span', array('class' => 'caret'), '');
346
345
347
-
return javelin_tag(
348
-
'a',
349
-
array(
350
-
'class' => 'button grey dropdown',
351
-
'meta' => $meta,
352
-
'href' => idx($meta, 'detailURI', '#'),
353
-
'target' => '_blank',
354
-
'sigil' => 'differential-view-options',
355
-
),
356
-
array(pht('View Options'), $caret));
346
+
return id(new PHUIButtonView())
347
+
->setTag('a')
348
+
->setText(pht('View Options'))
349
+
->setIcon('fa-bars')
350
+
->setColor(PHUIButtonView::GREY)
351
+
->setHref(idx($meta, 'detailURI', '#'))
352
+
->setMetadata($meta)
353
+
->addSigil('differential-view-options');
354
+
357
355
}
358
356
359
357
}
+3
-6
webroot/rsrc/css/application/differential/changeset-view.css
+3
-6
webroot/rsrc/css/application/differential/changeset-view.css
···
348
348
margin-right: 12px;
349
349
}
350
350
351
-
.device-phone .differential-changeset-buttons {
352
-
float: none;
353
-
margin: 0 0 8px 4px;
354
-
}
355
-
356
-
.differential-changeset-buttons a.button {
351
+
.device-phone .differential-changeset-buttons .button .phui-button-text {
352
+
visibility: hidden;
353
+
width: 0;
357
354
margin-left: 8px;
358
355
}
359
356