@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Move the Git LFS gate to dedicated (non-prototype) config
Summary: See PHI131. Ref T7789. Although this probably isn't 100% complete, there don't seem to be any actual, known, practical blocking issues remaining (everything is either heresay or not reproducible).
Test Plan: Tried to push LFS locally, got blocked with a helpful message. Enabled setting, tried to push LFS locally, got a successful push.
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T7789
Differential Revision: https://secure.phabricator.com/D18825
+15
-3
+14
-1
src/applications/diffusion/config/PhabricatorDiffusionConfigOptions.php
+14
-1
src/applications/diffusion/config/PhabricatorDiffusionConfigOptions.php
···
101
101
->setBoolOptions(
102
102
array(
103
103
pht('Allow HTTP Basic Auth'),
104
-
pht('Disable HTTP Basic Auth'),
104
+
pht('Disallow HTTP Basic Auth'),
105
105
))
106
106
->setSummary(pht('Enable HTTP Basic Auth for repositories.'))
107
107
->setDescription(
···
115
115
"barrier to attackers than SSH does.\n\n".
116
116
"Consider using SSH for authenticated access to repositories ".
117
117
"instead of HTTP.")),
118
+
$this->newOption('diffusion.allow-git-lfs', 'bool', false)
119
+
->setBoolOptions(
120
+
array(
121
+
pht('Allow Git LFS'),
122
+
pht('Disallow Git LFS'),
123
+
))
124
+
->setLocked(true)
125
+
->setSummary(pht('Allow Git Large File Storage (LFS).'))
126
+
->setDescription(
127
+
pht(
128
+
'Phabricator supports Git LFS, a Git extension for storing large '.
129
+
'files alongside a repository. Activate this setting to allow '.
130
+
'the extension to store file data in Phabricator.')),
118
131
$this->newOption('diffusion.ssh-user', 'string', null)
119
132
->setLocked(true)
120
133
->setSummary(pht('Login username for SSH connections to repositories.'))
+1
-2
src/applications/repository/storage/PhabricatorRepository.php
+1
-2
src/applications/repository/storage/PhabricatorRepository.php