@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix an issue where blame could fatal for unrecognized authors
Summary: See PHI255. See <https://discourse.phabricator-community.org/t/error-generating-blame-data/766>.
Test Plan:
- Viewed a file contributed to by users with no Phabricator user accounts, in Diffusion.
- Enabled blame.
- Before patch: blame failed, fatal in logs.
- After patch: blame worked.
Reviewers: amckinley
Reviewed By: amckinley
Differential Revision: https://secure.phabricator.com/D18833
+9
-5
+9
-5
src/applications/diffusion/controller/DiffusionBrowseController.php
+9
-5
src/applications/diffusion/controller/DiffusionBrowseController.php
···
1804
1804
// revision. We just render a blank for alignment.
1805
1805
$style = null;
1806
1806
$href = null;
1807
+
$sigil = null;
1808
+
$meta = null;
1807
1809
} else {
1808
1810
$src = $handles[$phid]->getImageURI();
1809
1811
$style = 'background-image: url('.$src.');';
1810
1812
$href = $handles[$phid]->getURI();
1813
+
$sigil = 'has-tooltip';
1814
+
$meta = array(
1815
+
'tip' => $handles[$phid]->getName(),
1816
+
'align' => 'E',
1817
+
);
1811
1818
}
1812
1819
1813
1820
$links[$phid] = javelin_tag(
···
1816
1823
'class' => 'diffusion-author-link',
1817
1824
'style' => $style,
1818
1825
'href' => $href,
1819
-
'sigil' => 'has-tooltip',
1820
-
'meta' => array(
1821
-
'tip' => $handles[$phid]->getName(),
1822
-
'align' => 'E',
1823
-
),
1826
+
'sigil' => $sigil,
1827
+
'meta' => $meta,
1824
1828
));
1825
1829
}
1826
1830