@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Clean up "Revisions/Commits" table in Maniphest slightly
Summary: Ref T13440. Give the table more obvious visual structure and get rid of the largely useless header columns.
Test Plan: Viewed table, saw a slightly cleaner result.
Maniphest Tasks: T13440
Differential Revision: https://secure.phabricator.com/D20885
+17
-17
+3
-3
resources/celerity/map.php
+3
-3
resources/celerity/map.php
···
9
9
'names' => array(
10
10
'conpherence.pkg.css' => '3c8a0668',
11
11
'conpherence.pkg.js' => '020aebcf',
12
-
'core.pkg.css' => '9a391b14',
12
+
'core.pkg.css' => '77de226f',
13
13
'core.pkg.js' => '6e5c894f',
14
14
'differential.pkg.css' => '607c84be',
15
15
'differential.pkg.js' => '1b97518d',
···
30
30
'rsrc/css/aphront/notification.css' => '30240bd2',
31
31
'rsrc/css/aphront/panel-view.css' => '46923d46',
32
32
'rsrc/css/aphront/phabricator-nav-view.css' => 'f8a0c1bf',
33
-
'rsrc/css/aphront/table-view.css' => '061e45eb',
33
+
'rsrc/css/aphront/table-view.css' => '0bb61df1',
34
34
'rsrc/css/aphront/tokenizer.css' => 'b52d0668',
35
35
'rsrc/css/aphront/tooltip.css' => 'e3f2412f',
36
36
'rsrc/css/aphront/typeahead-browse.css' => 'b7ed02d2',
···
535
535
'aphront-list-filter-view-css' => 'feb64255',
536
536
'aphront-multi-column-view-css' => 'fbc00ba3',
537
537
'aphront-panel-view-css' => '46923d46',
538
-
'aphront-table-view-css' => '061e45eb',
538
+
'aphront-table-view-css' => '0bb61df1',
539
539
'aphront-tokenizer-control-css' => 'b52d0668',
540
540
'aphront-tooltip-css' => 'e3f2412f',
541
541
'aphront-typeahead-control-css' => '8779483d',
+9
-13
src/applications/maniphest/controller/ManiphestTaskDetailController.php
+9
-13
src/applications/maniphest/controller/ManiphestTaskDetailController.php
···
593
593
594
594
$handle_phids = array();
595
595
$any_linked = false;
596
+
$any_status = false;
596
597
597
598
$idx = 0;
598
599
$objects = array();
···
623
624
->setIcon($status->getIcon())
624
625
->setColor($status->getColor())
625
626
->setName($status->getName());
626
-
627
627
}
628
628
}
629
629
···
750
750
if ($repository_phid !== $last_repository) {
751
751
$repository_link = null;
752
752
if ($repository_phid) {
753
-
$repository_link = $handles[$repository_phid]->renderLink();
753
+
$repository_handle = $handles[$repository_phid];
754
754
$rows[] = array(
755
-
$repository_link,
755
+
$repository_handle->renderLink(),
756
756
);
757
757
$rowd[] = true;
758
758
}
···
772
772
->setIcon($handle->getIcon());
773
773
774
774
$status_view = $object['status'];
775
+
if ($status_view) {
776
+
$any_status = true;
777
+
}
775
778
776
779
$revision_tags = array();
777
780
foreach ($object['revisionPHIDs'] as $link_phid) {
···
797
800
$changes_table = id(new AphrontTableView($rows))
798
801
->setNoDataString(pht('This task has no related commits or revisions.'))
799
802
->setRowDividers($rowd)
800
-
->setHeaders(
801
-
array(
802
-
null,
803
-
null,
804
-
null,
805
-
pht('Revision/Commit'),
806
-
))
807
803
->setColumnClasses(
808
804
array(
809
-
'center',
805
+
'indent center',
810
806
null,
811
807
null,
812
808
'wide pri object-link',
···
814
810
->setColumnVisibility(
815
811
array(
816
812
true,
817
-
true,
813
+
$any_status,
818
814
$any_linked,
819
815
true,
820
816
))
821
817
->setDeviceVisibility(
822
818
array(
823
819
false,
824
-
true,
820
+
$any_status,
825
821
false,
826
822
true,
827
823
));
+1
-1
src/view/control/AphrontTableView.php
+1
-1
src/view/control/AphrontTableView.php