@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Clean up some more carnage from D6416
Summary: rPad17c99c1b0222292a47ca79561a356cb8b5a5d5 stopped the fatal and this provides the forward fix. I think this is what a forward fix is anyway.
Test Plan: viewed a revision (D63 is my boy) and no fatals
Reviewers: epriestley
Reviewed By: epriestley
CC: aran, Korvin
Differential Revision: https://secure.phabricator.com/D6448
+16
-5
+5
-4
src/applications/differential/controller/DifferentialRevisionViewController.php
+5
-4
src/applications/differential/controller/DifferentialRevisionViewController.php
···
223
223
$visible_changesets = $changesets;
224
224
}
225
225
226
-
$revision_detail = new DifferentialRevisionDetailView();
227
-
$revision_detail->setRevision($revision);
228
-
$revision_detail->setDiff(end($diffs));
229
-
$revision_detail->setAuxiliaryFields($aux_fields);
226
+
$revision_detail = id(new DifferentialRevisionDetailView())
227
+
->setRevision($revision)
228
+
->setDiff(end($diffs))
229
+
->setAuxiliaryFields($aux_fields)
230
+
->setURI($request->getRequestURI());
230
231
231
232
$actions = $this->getRevisionActions($revision);
232
233
+11
-1
src/applications/differential/view/DifferentialRevisionDetailView.php
+11
-1
src/applications/differential/view/DifferentialRevisionDetailView.php
···
6
6
private $actions;
7
7
private $auxiliaryFields = array();
8
8
private $diff;
9
+
private $uri;
10
+
11
+
public function setURI($uri) {
12
+
$this->uri = $uri;
13
+
return $this;
14
+
}
15
+
public function getURI() {
16
+
return $this->uri;
17
+
}
9
18
10
19
public function setDiff(DifferentialDiff $diff) {
11
20
$this->diff = $diff;
···
45
54
46
55
$actions = id(new PhabricatorActionListView())
47
56
->setUser($user)
48
-
->setObject($revision);
57
+
->setObject($revision)
58
+
->setObjectURI($this->getURI());
49
59
foreach ($this->getActions() as $action) {
50
60
$obj = id(new PhabricatorActionView())
51
61
->setIcon(idx($action, 'icon', 'edit'))