@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

In Differential, filter repository operations to just "Land" operations again

Summary:
Reverts D18276. See PHI18 for discussion. The additional rules here (roughly, "only show the first successful operation") didn't actually work out for the other types of operations.

This is all just figuring out a stopgap, T12935 and other changes should eventually provide real pathways here.

Test Plan: Straight revert.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D18281

+4 -4
+4 -4
src/applications/differential/controller/DifferentialRevisionViewController.php
··· 1051 1051 return null; 1052 1052 } 1053 1053 1054 - // NOTE: The upstream currently supports only "Land" operations, but 1055 - // third parties have other operations (see PHI18). For now, we show any 1056 - // operation that exists. We'll refine this in the future. 1057 - 1058 1054 $operations = id(new DrydockRepositoryOperationQuery()) 1059 1055 ->setViewer($viewer) 1060 1056 ->withObjectPHIDs(array($revision->getPHID())) 1061 1057 ->withIsDismissed(false) 1058 + ->withOperationTypes( 1059 + array( 1060 + DrydockLandRepositoryOperation::OPCONST, 1061 + )) 1062 1062 ->execute(); 1063 1063 if (!$operations) { 1064 1064 return null;