recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Make blame UI recover gracefully if Identities haven't been built yet for a commit

Summary:
See PHI1014. We may not have Identities if you race the import pipeline, or in some other cases which are more "bug" / "missing migration"-flavored.

Load the commit data so we can fall back to it if we don't have identities.

Test Plan:
- Wiped out all my identities with `UPDATE ... SET authorIdentityPHID = NULL WHERE ...`.
- Before change: blame fataled with `Attempting to access attached data on PhabricatorRepositoryCommit (via getCommitData()), but the data is not actually attached.`.
- After change: blame falls back gracefully.
- Restored identities with `bin/repository rebuild-identities`, checked blame again.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D19958

epriestley e48c3669 84f94994

+3
+3
src/applications/diffusion/controller/DiffusionBlameController.php
··· 25 25 ->withRepository($repository) 26 26 ->withIdentifiers($identifiers) 27 27 ->needIdentities(true) 28 + // See PHI1014. If identities haven't been built yet, we may need to 29 + // fall back to raw commit data. 30 + ->needCommitData(true) 28 31 ->execute(); 29 32 $commits = mpull($commits, null, 'getCommitIdentifier'); 30 33 } else {