@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix arguments count in DifferentialDiffCreateTransaction::buildHeraldAdapter() call
Summary: Closes T16513
Test Plan: Run static code analysis; read the code.
Reviewers: O1 Blessed Committers, mainframe98
Reviewed By: O1 Blessed Committers, mainframe98
Subscribers: mainframe98, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Maniphest Tasks: T16513
Differential Revision: https://we.phorge.it/D26777
+1
-1
+1
-1
src/applications/differential/xaction/DifferentialDiffCreateTransaction.php
+1
-1
src/applications/differential/xaction/DifferentialDiffCreateTransaction.php
···
62
62
$diff = clone $object;
63
63
$diff = $this->updateDiffFromDict($diff, $xaction->getNewValue());
64
64
65
-
$adapter = $this->buildHeraldAdapter($diff, $xactions);
65
+
$adapter = $this->buildHeraldAdapter($diff);
66
66
$adapter->setContentSource($xaction->getContentSource());
67
67
$adapter->setIsNewObject(true);
68
68