@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Improve Dark Mode for borders of PHUIBoxView and Setup issues
Summary:
Do not hardcode the border of some boxes to `#e2e2e2` which is unnecessarily bright in Dark Mode but set the `{$lightgreyborder}` variable instead which corresponds to `#C7CCD9` in Default Mode - close enough.
Refs T15056
Test Plan:
* Go to http://phorge.localhost/settings/panel/display/ and set `Accessibility` to `Dark Mode (Experimental)`
* Go to http://phorge.localhost/settings/panel/apitokens/ and look at the box
* Go to http://phorge.localhost/config/issue/ and open one of the listed issues
* Scroll down on one of the listed issues and check the "To continue, resolve this problem and reload the page." box
Reviewers: O1 Blessed Committers, valerio.bozzolan
Reviewed By: O1 Blessed Committers, valerio.bozzolan
Subscribers: amybones, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Maniphest Tasks: T15056
Differential Revision: https://we.phorge.it/D26232
+15
-15
+5
-5
resources/celerity/map.php
+5
-5
resources/celerity/map.php
···
9
9
'names' => array(
10
10
'conpherence.pkg.css' => 'beb13d57',
11
11
'conpherence.pkg.js' => '020aebcf',
12
-
'core.pkg.css' => '6edc10db',
12
+
'core.pkg.css' => '0d46cba7',
13
13
'core.pkg.js' => '9250c090',
14
14
'dark-console.pkg.js' => '187792c2',
15
15
'differential.pkg.css' => 'abdb4fe9',
···
44
44
'rsrc/css/application/conduit/conduit-api.css' => 'ce2cfc41',
45
45
'rsrc/css/application/config/config-options.css' => '25d545a9',
46
46
'rsrc/css/application/config/config-template.css' => '20babf50',
47
-
'rsrc/css/application/config/setup-issue.css' => '512adefd',
47
+
'rsrc/css/application/config/setup-issue.css' => '46111bd0',
48
48
'rsrc/css/application/config/unhandled-exception.css' => '9ecfc00d',
49
49
'rsrc/css/application/conpherence/color.css' => 'b17746b0',
50
50
'rsrc/css/application/conpherence/durable-column.css' => '236e57cc',
···
133
133
'rsrc/css/phui/phui-badge.css' => 'aa49028c',
134
134
'rsrc/css/phui/phui-basic-nav-view.css' => '09d5192d',
135
135
'rsrc/css/phui/phui-big-info-view.css' => '362ad37b',
136
-
'rsrc/css/phui/phui-box.css' => '539be5a8',
136
+
'rsrc/css/phui/phui-box.css' => 'd315719b',
137
137
'rsrc/css/phui/phui-bulk-editor.css' => '374d5e30',
138
138
'rsrc/css/phui/phui-chart.css' => '4ad6694c',
139
139
'rsrc/css/phui/phui-cms.css' => '9f142cca',
···
771
771
'phui-badge-view-css' => 'aa49028c',
772
772
'phui-basic-nav-view-css' => '09d5192d',
773
773
'phui-big-info-view-css' => '362ad37b',
774
-
'phui-box-css' => '539be5a8',
774
+
'phui-box-css' => 'd315719b',
775
775
'phui-bulk-editor-css' => '374d5e30',
776
776
'phui-button-bar-css' => 'a4aa75c4',
777
777
'phui-button-css' => 'bca9bfe3',
···
850
850
'project-card-view-css' => '7294b671',
851
851
'project-triggers-css' => 'cd9c8bb9',
852
852
'project-view-css' => '2650c4c0',
853
-
'setup-issue-css' => '512adefd',
853
+
'setup-issue-css' => '46111bd0',
854
854
'sprite-login-css' => '0abdf921',
855
855
'sprite-tokens-css' => '330edc9e',
856
856
'syntax-default-css' => 'c0307dc6',
+8
-8
webroot/rsrc/css/application/config/setup-issue.css
+8
-8
webroot/rsrc/css/application/config/setup-issue.css
···
24
24
.setup-issue table {
25
25
width: 100%;
26
26
border-collapse: collapse;
27
-
border: 1px solid #e2e2e2;
27
+
border: 1px solid {$lightgreyborder};
28
28
}
29
29
30
30
.setup-issue table th {
31
31
text-align: right;
32
32
width: 30%;
33
33
background: {$lightbluebackground};
34
-
border: 1px solid #e2e2e2;
34
+
border: 1px solid {$lightgreyborder};
35
35
padding: 8px;
36
36
}
37
37
38
38
.setup-issue table td {
39
-
border: 1px solid #e2e2e2;
39
+
border: 1px solid {$lightgreyborder};
40
40
padding: 8px;
41
41
word-break: break-word;
42
42
}
43
43
44
44
.setup-issue pre {
45
45
width: auto;
46
-
border: 1px solid #e2e2e2;
46
+
border: 1px solid {$lightgreyborder};
47
47
padding: 12px;
48
48
background: {$lightbluebackground};
49
49
overflow-x: auto;
···
77
77
font-size: 15px;
78
78
font-weight: bold;
79
79
color: {$bluetext};
80
-
border-bottom: 1px solid #e2e2e2;
80
+
border-bottom: 1px solid {$lightgreyborder};
81
81
overflow: hidden;
82
82
padding: 16px;
83
83
line-height: 24px;
···
110
110
111
111
.setup-issue-next {
112
112
padding: 12px;
113
-
border: 1px solid #BFCFDA;
114
-
background: #daeaf3;
113
+
border: 1px solid {$lightblueborder};
114
+
background: {$lightblue};
115
115
text-align: center;
116
116
margin: 12px 0;
117
-
color: #2980b9;
117
+
color: {$blacktext};
118
118
border-radius: 3px;
119
119
}
120
120
+2
-2
webroot/rsrc/css/phui/phui-box.css
+2
-2
webroot/rsrc/css/phui/phui-box.css
···
123
123
/* Config Boxes */
124
124
125
125
.phui-box-white-config.phui-box-border {
126
-
border-color: #e2e2e2;
126
+
border-color: {$lightgreyborder};
127
127
border-radius: 3px;
128
128
}
129
129
···
132
132
}
133
133
134
134
.phui-box-white-config .phui-header-shell {
135
-
border-bottom: 1px solid #e2e2e2;
135
+
border-bottom: 1px solid {$lightgreyborder};
136
136
overflow: hidden;
137
137
padding: 0 16px 16px;
138
138
}