@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Homepage sprucing, spacing normalization
Summary: Cleans up the homepage a little bit. Removes the subheaders and buttons, links the panel header, and adds an icon for further hinting. Also aligned things up to the common 16px gutter.
Test Plan: Tested home, differential, and maniphest. Screenshotted changes
Reviewers: epriestley, btrahan
Reviewed By: epriestley
CC: Korvin, epriestley, aran
Differential Revision: https://secure.phabricator.com/D8034
+56
-84
+8
-8
resources/celerity/map.php
+8
-8
resources/celerity/map.php
···
7
7
return array(
8
8
'names' =>
9
9
array(
10
-
'core.pkg.css' => '76a5c45b',
10
+
'core.pkg.css' => '69c32d07',
11
11
'core.pkg.js' => 'c907bd96',
12
12
'darkconsole.pkg.js' => 'ca8671ce',
13
13
'differential.pkg.css' => '5a65a762',
···
15
15
'diffusion.pkg.css' => '3783278d',
16
16
'diffusion.pkg.js' => '7b51e80a',
17
17
'javelin.pkg.js' => '4dda9183',
18
-
'maniphest.pkg.css' => '1f0780dc',
18
+
'maniphest.pkg.css' => '6944ad50',
19
19
'maniphest.pkg.js' => '1e8f11af',
20
20
'rsrc/css/aphront/aphront-bars.css' => '231ac33c',
21
21
'rsrc/css/aphront/aphront-notes.css' => '6acadd3f',
···
29
29
'rsrc/css/aphront/multi-column.css' => '05bbd016',
30
30
'rsrc/css/aphront/notification.css' => '6901121e',
31
31
'rsrc/css/aphront/pager-view.css' => '2e3539af',
32
-
'rsrc/css/aphront/panel-view.css' => '35c2458b',
32
+
'rsrc/css/aphront/panel-view.css' => '5846dfa2',
33
33
'rsrc/css/aphront/phabricator-nav-view.css' => 'd0d4a509',
34
34
'rsrc/css/aphront/request-failure-view.css' => 'da14df31',
35
35
'rsrc/css/aphront/table-view.css' => '92a719ca',
···
77
77
'rsrc/css/application/maniphest/batch-editor.css' => '78444bc1',
78
78
'rsrc/css/application/maniphest/report.css' => '6fc16517',
79
79
'rsrc/css/application/maniphest/task-edit.css' => '8e23031b',
80
-
'rsrc/css/application/maniphest/task-summary.css' => 'adb7495a',
80
+
'rsrc/css/application/maniphest/task-summary.css' => '0cabd9a6',
81
81
'rsrc/css/application/objectselector/object-selector.css' => '029a133d',
82
82
'rsrc/css/application/owners/owners-path-editor.css' => '2f00933b',
83
83
'rsrc/css/application/paste/paste.css' => 'aa1767d1',
···
136
136
'rsrc/css/phui/phui-info-panel.css' => '27ea50a1',
137
137
'rsrc/css/phui/phui-list.css' => '2edb76cf',
138
138
'rsrc/css/phui/phui-object-box.css' => '4f916b80',
139
-
'rsrc/css/phui/phui-object-item-list-view.css' => 'e8192ada',
139
+
'rsrc/css/phui/phui-object-item-list-view.css' => 'c177f587',
140
140
'rsrc/css/phui/phui-pinboard-view.css' => '53c5fca0',
141
141
'rsrc/css/phui/phui-property-list-view.css' => 'dbf53b12',
142
142
'rsrc/css/phui/phui-remarkup-preview.css' => '19ad512b',
···
482
482
'aphront-multi-column-view-css' => '05bbd016',
483
483
'aphront-notes' => '6acadd3f',
484
484
'aphront-pager-view-css' => '2e3539af',
485
-
'aphront-panel-view-css' => '35c2458b',
485
+
'aphront-panel-view-css' => '5846dfa2',
486
486
'aphront-request-failure-view-css' => 'da14df31',
487
487
'aphront-table-view-css' => '92a719ca',
488
488
'aphront-tokenizer-control-css' => 'd888465e',
···
659
659
'maniphest-batch-editor' => '78444bc1',
660
660
'maniphest-report-css' => '6fc16517',
661
661
'maniphest-task-edit-css' => '8e23031b',
662
-
'maniphest-task-summary-css' => 'adb7495a',
662
+
'maniphest-task-summary-css' => '0cabd9a6',
663
663
'multirow-row-manager' => 'e7076916',
664
664
'owners-path-editor' => '46efd18e',
665
665
'owners-path-editor-css' => '2f00933b',
···
743
743
'phui-info-panel-css' => '27ea50a1',
744
744
'phui-list-view-css' => '2edb76cf',
745
745
'phui-object-box-css' => '4f916b80',
746
-
'phui-object-item-list-view-css' => 'e8192ada',
746
+
'phui-object-item-list-view-css' => 'c177f587',
747
747
'phui-pinboard-view-css' => '53c5fca0',
748
748
'phui-property-list-view-css' => 'dbf53b12',
749
749
'phui-remarkup-preview-css' => '19ad512b',
+29
-66
src/applications/directory/controller/PhabricatorDirectoryMainController.php
+29
-66
src/applications/directory/controller/PhabricatorDirectoryMainController.php
···
128
128
'Nothing appears to be critically broken right now.');
129
129
}
130
130
131
+
$href = '/maniphest/?statuses[]=0&priorities[]='.$unbreak_now.'#R';
132
+
$title = pht('Unbreak Now!');
131
133
$panel = new AphrontPanelView();
132
-
$panel->setHeader('Unbreak Now!');
133
-
$panel->setCaption('Open tasks with "Unbreak Now!" priority.');
134
-
$panel->addButton(
135
-
phutil_tag(
136
-
'a',
137
-
array(
138
-
'href' => '/maniphest/?statuses[]=0&priorities[]='.$unbreak_now.'#R',
139
-
'class' => 'grey button',
140
-
),
141
-
"View All Unbreak Now \xC2\xBB"));
142
-
134
+
$panel->setHeader($this->renderSectionHeader($title, $href));
143
135
$panel->appendChild($this->buildTaskListView($tasks));
144
136
$panel->setNoBackground();
145
137
···
180
172
'need triage.'));
181
173
}
182
174
175
+
$title = pht('Needs Triage');
176
+
$href = '/maniphest/?statuses[]=0&priorities[]='.$needs_triage.
177
+
'&userProjects[]='.$user->getPHID().'#R';
183
178
$panel = new AphrontPanelView();
184
-
$panel->setHeader('Needs Triage');
185
-
$panel->setCaption(hsprintf(
186
-
'Open tasks with "Needs Triage" priority in '.
187
-
'<a href="/project/">projects you are a member of</a>.'));
188
-
189
-
$panel->addButton(
190
-
phutil_tag(
191
-
'a',
192
-
array(
193
-
'href' => '/maniphest/?statuses[]=0&priorities[]='.$needs_triage.
194
-
'&userProjects[]='.$user->getPHID().'#R',
195
-
'class' => 'grey button',
196
-
),
197
-
"View All Triage \xC2\xBB"));
179
+
$panel->setHeader($this->renderSectionHeader($title, $href));
198
180
$panel->appendChild($this->buildTaskListView($tasks));
199
181
$panel->setNoBackground();
200
182
···
223
205
'No revisions are waiting on you.');
224
206
}
225
207
208
+
$title = pht('Revisions Waiting on You');
209
+
$href = '/differential';
226
210
$panel = new AphrontPanelView();
227
-
$panel->setHeader('Revisions Waiting on You');
228
-
$panel->setCaption('Revisions waiting for you for review or commit.');
229
-
230
-
$panel->addButton(
231
-
phutil_tag(
232
-
'a',
233
-
array(
234
-
'href' => '/differential/',
235
-
'class' => 'button grey',
236
-
),
237
-
"View Active Revisions \xC2\xBB"));
211
+
$panel->setHeader($this->renderSectionHeader($title, $href));
238
212
239
213
$revision_view = id(new DifferentialRevisionListView())
240
214
->setHighlightAge(true)
···
288
262
'You have no assigned tasks.');
289
263
}
290
264
265
+
$title = pht('Assigned Tasks');
266
+
$href = '/maniphest';
291
267
$panel = new AphrontPanelView();
292
-
$panel->setHeader('Assigned Tasks');
293
-
294
-
$panel->addButton(
295
-
phutil_tag(
296
-
'a',
297
-
array(
298
-
'href' => '/maniphest/',
299
-
'class' => 'button grey',
300
-
),
301
-
"View Active Tasks \xC2\xBB"));
268
+
$panel->setHeader($this->renderSectionHeader($title, $href));
302
269
$panel->appendChild($this->buildTaskListView($tasks));
303
270
$panel->setNoBackground();
304
271
···
390
357
return $container;
391
358
}
392
359
360
+
private function renderSectionHeader($title, $href) {
361
+
$header = phutil_tag(
362
+
'a',
363
+
array(
364
+
'href' => $href,
365
+
),
366
+
$title);
367
+
return $header;
368
+
}
369
+
393
370
private function renderMiniPanel($title, $body) {
394
371
$panel = new AphrontMiniPanelView();
395
372
$panel->appendChild(
···
435
412
$handles = $this->loadViewerHandles($phids);
436
413
$view->setHandles($handles);
437
414
415
+
$title = pht('Audits');
416
+
$href = '/audit/';
438
417
$panel = new AphrontPanelView();
439
-
$panel->setHeader('Audits');
440
-
$panel->setCaption('Commits awaiting your audit.');
418
+
$panel->setHeader($this->renderSectionHeader($title, $href));
441
419
$panel->appendChild($view);
442
-
$panel->addButton(
443
-
phutil_tag(
444
-
'a',
445
-
array(
446
-
'href' => '/audit/',
447
-
'class' => 'button grey',
448
-
),
449
-
"View Active Audits \xC2\xBB"));
450
420
$panel->setNoBackground();
451
421
452
422
return $panel;
···
480
450
$handles = $this->loadViewerHandles($phids);
481
451
$view->setHandles($handles);
482
452
453
+
$title = pht('Problem Commits');
454
+
$href = '/audit/';
483
455
$panel = new AphrontPanelView();
484
-
$panel->setHeader('Problem Commits');
485
-
$panel->setCaption('Commits which auditors have raised concerns about.');
456
+
$panel->setHeader($this->renderSectionHeader($title, $href));
486
457
$panel->appendChild($view);
487
-
$panel->addButton(
488
-
phutil_tag(
489
-
'a',
490
-
array(
491
-
'href' => '/audit/',
492
-
'class' => 'button grey',
493
-
),
494
-
"View Problem Commits \xC2\xBB"));
495
458
$panel->setNoBackground();
496
459
497
460
return $panel;
+15
-6
webroot/rsrc/css/aphront/panel-view.css
+15
-6
webroot/rsrc/css/aphront/panel-view.css
···
8
8
border: 1px solid #c0c0c0;
9
9
border-width: 1px 0 0;
10
10
padding: 8px 16px;
11
-
margin: 20px 16px 40px 16px;
11
+
margin: 20px 16px 32px 16px;
12
12
}
13
13
14
14
.device-phone .aphront-panel-view {
···
32
32
.aphront-panel-view h1 {
33
33
font-size: 16px;
34
34
font-weight: bold;
35
-
color: {$darkgreytext};
35
+
color: {$darkbluetext};
36
36
text-shadow: 0 1px 1px #fff;
37
37
padding: 4px 0 0 0;
38
38
}
39
39
40
+
.aphront-panel-view h1 a {
41
+
color: {$darkbluetext};
42
+
text-decoration: none;
43
+
}
44
+
45
+
.aphront-panel-view h1 a:hover {
46
+
text-decoration: underline;
47
+
}
48
+
40
49
.aphront-panel-plain h1 {
41
-
padding: 0 0 4px 0;
50
+
padding: 0;
42
51
}
43
52
44
53
.aphront-panel-view-caption {
45
54
font-size: 11px;
46
55
color: {$greytext};
47
-
margin-top: -0.1em;
48
-
margin-bottom: 0.75em;
56
+
margin-top: 4px;
57
+
margin-bottom: 4px;
49
58
}
50
59
51
60
.aphront-panel-view-buttons {
···
113
122
.aphront-mini-panel-view {
114
123
background: #fff;
115
124
padding: 10px;
116
-
margin: 5px 20px;
125
+
margin: 4px 16px;
117
126
border: 1px solid {$lightgreyborder};
118
127
border-bottom: 1px solid {$greyborder};
119
128
}
+3
-3
webroot/rsrc/css/application/maniphest/task-summary.css
+3
-3
webroot/rsrc/css/application/maniphest/task-summary.css
···
3
3
*/
4
4
5
5
.maniphest-task-group {
6
-
padding-bottom: 30px;
6
+
padding-bottom: 24px;
7
7
}
8
8
9
9
.maniphest-batch-selected td {
···
75
75
}
76
76
77
77
.maniphest-list-container {
78
-
padding: 20px;
78
+
padding: 16px;
79
79
}
80
80
81
81
.device-phone .maniphest-list-container {
82
-
padding: 20px 5px;
82
+
padding: 20px 4px;
83
83
}