@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix fatal in rendering Phriction "Moved Away" stories
Summary:
Ref T13202. See PHI881. These stories have bad rendering methods, but they didn't previously render into the timeilne (since Phriction documents didn't have a timeline).
Update the rendering to work.
The rendered outcome isn't great (it isn't very clear or explicit about exactly what moved where), but I'll fix that in a followup. This is a net improvement since it doesn't fatal the page, at least.
Test Plan:
- Moved page "X" to "Y".
- Viewed the old page "X".
- Before patch: bad timeline story would fatal rendering.
- After patch: story renders, at least, just not great.
Reviewers: amckinley
Maniphest Tasks: T13202
Differential Revision: https://secure.phabricator.com/D19682
+4
-4
+4
-4
src/applications/phriction/xaction/PhrictionDocumentMoveAwayTransaction.php
+4
-4
src/applications/phriction/xaction/PhrictionDocumentMoveAwayTransaction.php
···
38
38
$new = $this->getNewValue();
39
39
40
40
return pht(
41
-
'%s moved this document to %s',
41
+
'%s moved this document to %s.',
42
42
$this->renderAuthor(),
43
-
$this->renderHandleLink($new['phid']));
43
+
$this->renderObject($new['phid']));
44
44
}
45
45
46
46
public function getTitleForFeed() {
47
47
$new = $this->getNewValue();
48
48
49
49
return pht(
50
-
'%s moved %s to %s',
50
+
'%s moved %s to %s.',
51
51
$this->renderAuthor(),
52
52
$this->renderObject(),
53
-
$this->renderHandleLink($new['phid']));
53
+
$this->renderObject($new['phid']));
54
54
}
55
55
56
56
public function getIcon() {