recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix PHP 8.1 "strlen(null)" exception which blocks creating a blog post

Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15357

Test Plan: Applied this change and created blog post at `/phame/post/view/3/blogpost/` rendered in web browser.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15357

Differential Revision: https://we.phorge.it/D25196

Andre Klapper e5caf433 eba8012d

+2 -1
+2 -1
src/applications/phame/storage/PhamePost.php
··· 67 67 $blog = $this->getBlog(); 68 68 $is_draft = $this->isDraft(); 69 69 $is_archived = $this->isArchived(); 70 - if (strlen($blog->getDomain()) && !$is_draft && !$is_archived) { 70 + if (phutil_nonempty_string($blog->getDomain()) && 71 + !$is_draft && !$is_archived) { 71 72 return $this->getExternalLiveURI(); 72 73 } else { 73 74 return $this->getInternalLiveURI();