recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Don't trigger audits for archived packages

Summary:
Ref T10939. This is just a bug. I thought this was what was described in T10174 but that's actually talking about something completely different.

Also make a `<select />` slightly easier to use.

Test Plan:
- Created a package with auditing enabled.
- Pushed a change.
- Saw audit trigger.
- Disabled the package, pushed a change.
- Before patch: saw audit trigger improperly.
- After patch: restarted daemons, then saw audit correctly not trigger.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10939

Differential Revision: https://secure.phabricator.com/D15907

epriestley e5f2ccc5 1c73ad6a

+6 -1
+1 -1
src/applications/owners/controller/PhabricatorOwnersPathsController.php
··· 82 82 } 83 83 } 84 84 85 - $repos = mpull($repos, 'getMonogram', 'getPHID'); 85 + $repos = mpull($repos, 'getDisplayName', 'getPHID'); 86 86 asort($repos); 87 87 88 88 $template = new AphrontTypeaheadTemplateView();
+5
src/applications/repository/worker/PhabricatorRepositoryCommitOwnersWorker.php
··· 51 51 continue; 52 52 } 53 53 54 + if ($package->isArchived()) { 55 + // Don't trigger audits if the package is archived. 56 + continue; 57 + } 58 + 54 59 if ($package->getAuditingEnabled()) { 55 60 $reasons = $this->checkAuditReasons($commit, $package); 56 61 if ($reasons) {