@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Update Facts for newPage
Summary: No UI updates, just swapping over to `newPage`
Test Plan: Pull up each page.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin, yelirekim
Differential Revision: https://secure.phabricator.com/D15601
+14
-14
+7
-8
src/applications/fact/controller/PhabricatorFactChartController.php
+7
-8
src/applications/fact/controller/PhabricatorFactChartController.php
···
77
77
$crumbs = $this->buildApplicationCrumbs();
78
78
$crumbs->addTextCrumb(pht('Chart'));
79
79
80
-
return $this->buildApplicationPage(
81
-
array(
82
-
$crumbs,
83
-
$box,
84
-
),
85
-
array(
86
-
'title' => pht('Chart'),
87
-
));
80
+
$title = pht('Chart');
81
+
82
+
return $this->newPage()
83
+
->setTitle($title)
84
+
->setCrumbs($crumbs)
85
+
->appendChild($box);
86
+
88
87
}
89
88
90
89
}
+7
-6
src/applications/fact/controller/PhabricatorFactHomeController.php
+7
-6
src/applications/fact/controller/PhabricatorFactHomeController.php
···
59
59
$crumbs = $this->buildApplicationCrumbs();
60
60
$crumbs->addTextCrumb(pht('Home'));
61
61
62
-
return $this->buildApplicationPage(
63
-
array(
64
-
$crumbs,
62
+
$title = pht('Facts');
63
+
64
+
return $this->newPage()
65
+
->setTitle($title)
66
+
->setCrumbs($crumbs)
67
+
->appendChild(array(
65
68
$chart_form,
66
69
$panel,
67
-
),
68
-
array(
69
-
'title' => pht('Facts'),
70
70
));
71
+
71
72
}
72
73
73
74
private function buildChartForm() {