@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Rename "Edit Column" to "Column Details"
Summary: Ref T9089. This link leads to a detail page, not an edit page, and is always visible by users with permission to see the column.
Test Plan: Clicked "Column Details" with and without edit permission.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T9089
Differential Revision: https://secure.phabricator.com/D14016
+5
-17
+4
-6
src/applications/project/controller/PhabricatorProjectBoardViewController.php
+4
-6
src/applications/project/controller/PhabricatorProjectBoardViewController.php
···
639
639
->setHref($batch_edit_uri)
640
640
->setDisabled(!$can_batch_edit);
641
641
642
-
$edit_uri = $this->getApplicationURI(
642
+
$detail_uri = $this->getApplicationURI(
643
643
'board/'.$this->id.'/column/'.$column->getID().'/');
644
644
645
645
$column_items[] = id(new PhabricatorActionView())
646
-
->setIcon('fa-pencil')
647
-
->setName(pht('Edit Column'))
648
-
->setHref($edit_uri)
649
-
->setDisabled(!$can_edit)
650
-
->setWorkflow(!$can_edit);
646
+
->setIcon('fa-columns')
647
+
->setName(pht('Column Details'))
648
+
->setHref($detail_uri);
651
649
652
650
$can_hide = ($can_edit && !$column->isDefaultColumn());
653
651
$hide_uri = 'board/'.$this->id.'/hide/'.$column->getID().'/';
+1
-11
src/applications/project/controller/PhabricatorProjectColumnDetailController.php
+1
-11
src/applications/project/controller/PhabricatorProjectColumnDetailController.php
···
17
17
->withIDs(array($project_id))
18
18
->needImages(true)
19
19
->executeOne();
20
-
21
20
if (!$project) {
22
21
return new Aphront404Response();
23
22
}
···
40
39
new PhabricatorProjectColumnTransactionQuery());
41
40
$timeline->setShouldTerminate(true);
42
41
43
-
$title = pht('%s', $column->getDisplayName());
42
+
$title = $column->getDisplayName();
44
43
45
44
$header = $this->buildHeaderView($column);
46
45
$actions = $this->buildActionView($column);
···
112
111
->setUser($viewer)
113
112
->setObject($column)
114
113
->setActionList($actions);
115
-
116
-
$descriptions = PhabricatorPolicyQuery::renderPolicyDescriptions(
117
-
$viewer,
118
-
$column);
119
-
120
-
$properties->addProperty(
121
-
pht('Editable By'),
122
-
$descriptions[PhabricatorPolicyCapability::CAN_EDIT]);
123
-
124
114
125
115
$limit = $column->getPointLimit();
126
116
$properties->addProperty(