recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix 'Add to Dashboard' issue with builtins

Summary: Ref T5307. Actually check the built in query with query, not engine.

Test Plan: Try a builtin query, and a custom query when making a dashboard panel.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Maniphest Tasks: T5307

Differential Revision: https://secure.phabricator.com/D17521

Chad Little e69f8f71 9b07adb8

+1 -1
+1 -1
src/applications/dashboard/controller/PhabricatorDashboardQueryPanelInstallController.php
··· 29 29 $engine = $engines[$v_engine]; 30 30 $engine->setViewer($viewer); 31 31 $good_query = false; 32 - if ($engine->isBuiltinQuery($v_engine)) { 32 + if ($engine->isBuiltinQuery($v_query)) { 33 33 $good_query = true; 34 34 } else { 35 35 $saved_query = id(new PhabricatorSavedQueryQuery())