@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Use correct transaction types when creating diffs

Summary: See T10214 for context. These transaction types are obviously wrong as far as I can tell.

Test Plan:
Created a revision and didn't see an error in the daemon log.

```lang=php
<?php

require_once dirname(__FILE__).'/phabricator/scripts/__init_script__.php';

$yelirekim = (new PhabricatorPeopleQuery)
->setViewer(PhabricatorUser::getOmnipotentUser())
->withUsernames(['yelirekim'])
->executeOne();

$raw_diff = (new PhabricatorDifferenceEngine)
->generateRawDiffFromFileContent('oldfile', 'newfile');
$diff = (new ConduitCall('differential.createrawdiff', [
'diff' => $raw_diff,
]))
->setUser($yelirekim)
->execute();

$xactions = (new DifferentialDiffTransactionQuery)
->setViewer($yelirekim)
->withObjectPHIDs([$diff['phid']])
->execute();

foreach ($xactions as $xaction) {
echo $xaction->getPHID().':'.$xaction->getTitle().PHP_EOL;
}
```

for sanity

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: michaeljs1990, epriestley

Differential Revision: https://secure.phabricator.com/D15112

authored by

Mike Riley and committed by
epriestley
e7195628 a9e2e6c5

+3 -3
+1 -1
src/applications/differential/conduit/DifferentialCreateDiffConduitAPIMethod.php
··· 137 137 ); 138 138 139 139 $xactions = array( 140 - id(new DifferentialTransaction()) 140 + id(new DifferentialDiffTransaction()) 141 141 ->setTransactionType(DifferentialDiffTransaction::TYPE_DIFF_CREATE) 142 142 ->setNewValue($diff_data_dict), 143 143 );
+2 -2
src/applications/differential/conduit/DifferentialCreateRawDiffConduitAPIMethod.php
··· 72 72 ); 73 73 74 74 $xactions = array( 75 - id(new DifferentialTransaction()) 75 + id(new DifferentialDiffTransaction()) 76 76 ->setTransactionType(DifferentialDiffTransaction::TYPE_DIFF_CREATE) 77 77 ->setNewValue($diff_data_dict), 78 78 ); 79 79 80 80 if ($request->getValue('viewPolicy')) { 81 - $xactions[] = id(new DifferentialTransaction()) 81 + $xactions[] = id(new DifferentialDiffTransaction()) 82 82 ->setTransactionType(PhabricatorTransactions::TYPE_VIEW_POLICY) 83 83 ->setNewValue($request->getValue('viewPolicy')); 84 84 }