@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix method visibility for `PhabricatorController` subclasses

Summary: Ref T6822.

Test Plan: Visual inspection. These methods are only called from within `PhabricatorController` subclasses.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6822

Differential Revision: https://secure.phabricator.com/D11241

+73 -74
+1 -1
src/applications/almanac/controller/AlmanacDeviceController.php
··· 2 2 3 3 abstract class AlmanacDeviceController extends AlmanacController { 4 4 5 - public function buildApplicationCrumbs() { 5 + protected function buildApplicationCrumbs() { 6 6 $crumbs = parent::buildApplicationCrumbs(); 7 7 8 8 $list_uri = $this->getApplicationURI('device/');
+1 -1
src/applications/almanac/controller/AlmanacDeviceListController.php
··· 16 16 return $this->delegateToController($controller); 17 17 } 18 18 19 - public function buildApplicationCrumbs() { 19 + protected function buildApplicationCrumbs() { 20 20 $crumbs = parent::buildApplicationCrumbs(); 21 21 22 22 $can_create = $this->hasApplicationCapability(
+1 -1
src/applications/almanac/controller/AlmanacNetworkController.php
··· 2 2 3 3 abstract class AlmanacNetworkController extends AlmanacController { 4 4 5 - public function buildApplicationCrumbs() { 5 + protected function buildApplicationCrumbs() { 6 6 $crumbs = parent::buildApplicationCrumbs(); 7 7 8 8 $list_uri = $this->getApplicationURI('network/');
+1 -1
src/applications/almanac/controller/AlmanacNetworkListController.php
··· 16 16 return $this->delegateToController($controller); 17 17 } 18 18 19 - public function buildApplicationCrumbs() { 19 + protected function buildApplicationCrumbs() { 20 20 $crumbs = parent::buildApplicationCrumbs(); 21 21 22 22 $can_create = $this->hasApplicationCapability(
+1 -1
src/applications/almanac/controller/AlmanacServiceController.php
··· 2 2 3 3 abstract class AlmanacServiceController extends AlmanacController { 4 4 5 - public function buildApplicationCrumbs() { 5 + protected function buildApplicationCrumbs() { 6 6 $crumbs = parent::buildApplicationCrumbs(); 7 7 8 8 $list_uri = $this->getApplicationURI('service/');
+1 -1
src/applications/almanac/controller/AlmanacServiceListController.php
··· 16 16 return $this->delegateToController($controller); 17 17 } 18 18 19 - public function buildApplicationCrumbs() { 19 + protected function buildApplicationCrumbs() { 20 20 $crumbs = parent::buildApplicationCrumbs(); 21 21 22 22 $can_create = $this->hasApplicationCapability(
+1 -1
src/applications/audit/controller/PhabricatorAuditController.php
··· 18 18 return $nav; 19 19 } 20 20 21 - public function buildApplicationMenu() { 21 + protected function buildApplicationMenu() { 22 22 return $this->buildSideNavView()->getMenu(); 23 23 } 24 24
+1 -1
src/applications/auth/controller/config/PhabricatorAuthProviderConfigController.php
··· 20 20 return $nav; 21 21 } 22 22 23 - public function buildApplicationMenu() { 23 + protected function buildApplicationMenu() { 24 24 return $this->buildSideNavView($for_app = true)->getMenu(); 25 25 } 26 26
+2 -2
src/applications/calendar/controller/PhabricatorCalendarController.php
··· 20 20 return $nav; 21 21 } 22 22 23 - public function buildApplicationMenu() { 23 + protected function buildApplicationMenu() { 24 24 return $this->buildSideNavView()->getMenu(); 25 25 } 26 26 27 - public function buildApplicationCrumbs() { 27 + protected function buildApplicationCrumbs() { 28 28 $crumbs = parent::buildApplicationCrumbs(); 29 29 30 30 $crumbs->addAction(
+1 -1
src/applications/config/controller/PhabricatorConfigController.php
··· 26 26 return $nav; 27 27 } 28 28 29 - public function buildApplicationMenu() { 29 + protected function buildApplicationMenu() { 30 30 return $this->buildSideNavView(null, true)->getMenu(); 31 31 } 32 32
+2 -2
src/applications/conpherence/controller/ConpherenceController.php
··· 4 4 5 5 private $conpherences; 6 6 7 - public function buildApplicationMenu() { 7 + protected function buildApplicationMenu() { 8 8 $nav = new PHUIListView(); 9 9 10 10 $nav->newLink( ··· 30 30 return $nav; 31 31 } 32 32 33 - public function buildApplicationCrumbs() { 33 + protected function buildApplicationCrumbs() { 34 34 $crumbs = parent::buildApplicationCrumbs(); 35 35 36 36 $crumbs
+2 -2
src/applications/countdown/controller/PhabricatorCountdownController.php
··· 21 21 return $nav; 22 22 } 23 23 24 - public function buildApplicationMenu() { 24 + protected function buildApplicationMenu() { 25 25 return $this->buildSideNavView($for_app = true)->getMenu(); 26 26 } 27 27 28 - public function buildApplicationCrumbs() { 28 + protected function buildApplicationCrumbs() { 29 29 $crumbs = parent::buildApplicationCrumbs(); 30 30 31 31 $crumbs->addAction(
+1 -1
src/applications/dashboard/controller/PhabricatorDashboardListController.php
··· 39 39 return $nav; 40 40 } 41 41 42 - public function buildApplicationCrumbs() { 42 + protected function buildApplicationCrumbs() { 43 43 $crumbs = parent::buildApplicationCrumbs(); 44 44 45 45 $crumbs->addAction(
+1 -1
src/applications/dashboard/controller/PhabricatorDashboardPanelListController.php
··· 36 36 return $nav; 37 37 } 38 38 39 - public function buildApplicationCrumbs() { 39 + protected function buildApplicationCrumbs() { 40 40 $crumbs = parent::buildApplicationCrumbs(); 41 41 42 42 $crumbs->addTextCrumb(pht('Panels'), $this->getApplicationURI().'panel/');
+1 -1
src/applications/dashboard/controller/PhabricatorDashboardViewController.php
··· 49 49 )); 50 50 } 51 51 52 - public function buildApplicationCrumbs() { 52 + protected function buildApplicationCrumbs() { 53 53 $crumbs = parent::buildApplicationCrumbs(); 54 54 $id = $this->id; 55 55
+2 -2
src/applications/differential/controller/DifferentialController.php
··· 2 2 3 3 abstract class DifferentialController extends PhabricatorController { 4 4 5 - public function buildApplicationCrumbs() { 5 + protected function buildApplicationCrumbs() { 6 6 $crumbs = parent::buildApplicationCrumbs(); 7 7 8 8 $crumbs->addAction( ··· 29 29 return $nav; 30 30 } 31 31 32 - public function buildApplicationMenu() { 32 + protected function buildApplicationMenu() { 33 33 return $this->buildSideNavView(true)->getMenu(); 34 34 } 35 35
+1 -1
src/applications/diffusion/controller/DiffusionRepositoryEditController.php
··· 3 3 abstract class DiffusionRepositoryEditController 4 4 extends DiffusionController { 5 5 6 - public function buildApplicationCrumbs($is_main = false) { 6 + protected function buildApplicationCrumbs($is_main = false) { 7 7 $crumbs = parent::buildApplicationCrumbs(); 8 8 9 9 if ($this->diffusionRequest) {
+1 -1
src/applications/diffusion/controller/DiffusionRepositoryListController.php
··· 37 37 return $nav; 38 38 } 39 39 40 - public function buildApplicationCrumbs() { 40 + protected function buildApplicationCrumbs() { 41 41 $crumbs = parent::buildApplicationCrumbs(); 42 42 43 43 $can_create = $this->hasApplicationCapability(
+1 -1
src/applications/drydock/controller/DrydockBlueprintController.php
··· 16 16 return $nav; 17 17 } 18 18 19 - public function buildApplicationCrumbs() { 19 + protected function buildApplicationCrumbs() { 20 20 $crumbs = parent::buildApplicationCrumbs(); 21 21 $crumbs->addTextCrumb( 22 22 pht('Blueprints'),
+1 -1
src/applications/drydock/controller/DrydockBlueprintListController.php
··· 22 22 return $this->delegateToController($controller); 23 23 } 24 24 25 - public function buildApplicationCrumbs() { 25 + protected function buildApplicationCrumbs() { 26 26 $can_create = $this->hasApplicationCapability( 27 27 DrydockCreateBlueprintsCapability::CAPABILITY); 28 28
+1 -1
src/applications/drydock/controller/DrydockController.php
··· 4 4 5 5 abstract function buildSideNavView(); 6 6 7 - public function buildApplicationMenu() { 7 + protected function buildApplicationMenu() { 8 8 return $this->buildSideNavView()->getMenu(); 9 9 } 10 10
+1 -1
src/applications/drydock/controller/DrydockLeaseController.php
··· 16 16 return $nav; 17 17 } 18 18 19 - public function buildApplicationCrumbs() { 19 + protected function buildApplicationCrumbs() { 20 20 $crumbs = parent::buildApplicationCrumbs(); 21 21 $crumbs->addTextCrumb( 22 22 pht('Leases'),
+1 -1
src/applications/drydock/controller/DrydockLogController.php
··· 16 16 return $nav; 17 17 } 18 18 19 - public function buildApplicationCrumbs() { 19 + protected function buildApplicationCrumbs() { 20 20 $crumbs = parent::buildApplicationCrumbs(); 21 21 $crumbs->addTextCrumb( 22 22 pht('Logs'),
+1 -1
src/applications/drydock/controller/DrydockResourceController.php
··· 16 16 return $nav; 17 17 } 18 18 19 - public function buildApplicationCrumbs() { 19 + protected function buildApplicationCrumbs() { 20 20 $crumbs = parent::buildApplicationCrumbs(); 21 21 $crumbs->addTextCrumb( 22 22 pht('Resources'),
+1 -1
src/applications/files/controller/PhabricatorFileListController.php
··· 21 21 return $this->delegateToController($controller); 22 22 } 23 23 24 - public function buildApplicationCrumbs() { 24 + protected function buildApplicationCrumbs() { 25 25 $crumbs = parent::buildApplicationCrumbs(); 26 26 $crumbs->addAction( 27 27 id(new PHUIListItemView())
+1 -1
src/applications/fund/controller/FundInitiativeListController.php
··· 40 40 return $nav; 41 41 } 42 42 43 - public function buildApplicationCrumbs() { 43 + protected function buildApplicationCrumbs() { 44 44 $crumbs = parent::buildApplicationCrumbs(); 45 45 46 46 $can_create = $this->hasApplicationCapability(
+1 -1
src/applications/harbormaster/controller/HarbormasterBuildableListController.php
··· 39 39 return $nav; 40 40 } 41 41 42 - public function buildApplicationMenu() { 42 + protected function buildApplicationMenu() { 43 43 return $this->buildSideNavView(true)->getMenu(); 44 44 } 45 45
+1 -1
src/applications/harbormaster/controller/HarbormasterController.php
··· 2 2 3 3 abstract class HarbormasterController extends PhabricatorController { 4 4 5 - public function buildApplicationCrumbs() { 5 + protected function buildApplicationCrumbs() { 6 6 $crumbs = parent::buildApplicationCrumbs(); 7 7 8 8 $crumbs->addAction(
+1 -1
src/applications/harbormaster/controller/HarbormasterPlanController.php
··· 2 2 3 3 abstract class HarbormasterPlanController extends HarbormasterController { 4 4 5 - public function buildApplicationCrumbs() { 5 + protected function buildApplicationCrumbs() { 6 6 $crumbs = parent::buildApplicationCrumbs(); 7 7 8 8 $crumbs->addTextCrumb(
+1 -1
src/applications/harbormaster/controller/HarbormasterPlanListController.php
··· 40 40 return $nav; 41 41 } 42 42 43 - public function buildApplicationMenu() { 43 + protected function buildApplicationMenu() { 44 44 return $this->buildSideNavView(true)->getMenu(); 45 45 } 46 46
+2 -2
src/applications/herald/controller/HeraldController.php
··· 16 16 return $response->setContent($page->render()); 17 17 } 18 18 19 - public function buildApplicationMenu() { 19 + protected function buildApplicationMenu() { 20 20 return $this->buildSideNavView(true)->getMenu(); 21 21 } 22 22 23 - public function buildApplicationCrumbs() { 23 + protected function buildApplicationCrumbs() { 24 24 $crumbs = parent::buildApplicationCrumbs(); 25 25 26 26 $crumbs->addAction(
+1 -1
src/applications/herald/controller/HeraldTranscriptListController.php
··· 23 23 return $nav; 24 24 } 25 25 26 - public function buildApplicationCrumbs() { 26 + protected function buildApplicationCrumbs() { 27 27 $crumbs = parent::buildApplicationCrumbs(); 28 28 29 29 $crumbs->addTextCrumb(
+1 -1
src/applications/legalpad/controller/LegalpadController.php
··· 22 22 return $nav; 23 23 } 24 24 25 - public function buildApplicationMenu() { 25 + protected function buildApplicationMenu() { 26 26 return $this->buildSideNav(true)->getMenu(); 27 27 } 28 28
+1 -1
src/applications/legalpad/controller/LegalpadDocumentListController.php
··· 21 21 return $this->delegateToController($controller); 22 22 } 23 23 24 - public function buildApplicationCrumbs() { 24 + protected function buildApplicationCrumbs() { 25 25 $crumbs = parent::buildApplicationCrumbs(); 26 26 27 27 $can_create = $this->hasApplicationCapability(
+1 -1
src/applications/legalpad/controller/LegalpadDocumentSignatureListController.php
··· 64 64 return $nav; 65 65 } 66 66 67 - public function buildApplicationCrumbs() { 67 + protected function buildApplicationCrumbs() { 68 68 $crumbs = parent::buildApplicationCrumbs(); 69 69 70 70 if ($this->document) {
+1 -1
src/applications/macro/controller/PhabricatorMacroController.php
··· 20 20 return $nav; 21 21 } 22 22 23 - public function buildApplicationMenu() { 23 + protected function buildApplicationMenu() { 24 24 return $this->buildSideNavView($for_app = true)->getMenu(); 25 25 } 26 26
+2 -2
src/applications/mailinglists/controller/PhabricatorMailingListsController.php
··· 21 21 return $nav; 22 22 } 23 23 24 - public function buildApplicationMenu() { 24 + protected function buildApplicationMenu() { 25 25 return $this->buildSideNavView(true)->getMenu(); 26 26 } 27 27 28 - public function buildApplicationCrumbs() { 28 + protected function buildApplicationCrumbs() { 29 29 $crumbs = parent::buildApplicationCrumbs(); 30 30 31 31 $crumbs->addAction(
+1 -1
src/applications/meta/controller/PhabricatorApplicationsController.php
··· 17 17 return $nav; 18 18 } 19 19 20 - public function buildApplicationMenu() { 20 + protected function buildApplicationMenu() { 21 21 return $this->buildSideNavView(true)->getMenu(); 22 22 } 23 23
+1 -1
src/applications/oauthserver/controller/client/PhabricatorOAuthClientListController.php
··· 22 22 return $this->delegateToController($controller); 23 23 } 24 24 25 - public function buildApplicationCrumbs() { 25 + protected function buildApplicationCrumbs() { 26 26 $crumbs = parent::buildApplicationCrumbs(); 27 27 28 28 $crumbs->addAction(
+1 -1
src/applications/owners/controller/PhabricatorOwnersController.php
··· 58 58 return $nav; 59 59 } 60 60 61 - public function buildApplicationMenu() { 61 + protected function buildApplicationMenu() { 62 62 return $this->buildSideNavView()->getMenu(); 63 63 } 64 64
+2 -2
src/applications/passphrase/controller/PassphraseController.php
··· 21 21 return $nav; 22 22 } 23 23 24 - public function buildApplicationMenu() { 24 + protected function buildApplicationMenu() { 25 25 return $this->buildSideNavView(true)->getMenu(); 26 26 } 27 27 28 - public function buildApplicationCrumbs() { 28 + protected function buildApplicationCrumbs() { 29 29 $crumbs = parent::buildApplicationCrumbs(); 30 30 31 31 $crumbs->addAction(
+2 -2
src/applications/paste/controller/PhabricatorPasteController.php
··· 21 21 return $nav; 22 22 } 23 23 24 - public function buildApplicationMenu() { 24 + protected function buildApplicationMenu() { 25 25 return $this->buildSideNavView(true)->getMenu(); 26 26 } 27 27 28 - public function buildApplicationCrumbs() { 28 + protected function buildApplicationCrumbs() { 29 29 $crumbs = parent::buildApplicationCrumbs(); 30 30 31 31 $crumbs->addAction(
+2 -2
src/applications/people/controller/PhabricatorPeopleController.php
··· 28 28 return $nav; 29 29 } 30 30 31 - public function buildApplicationMenu() { 31 + protected function buildApplicationMenu() { 32 32 return $this->buildSideNavView()->getMenu(); 33 33 } 34 34 35 - public function buildApplicationCrumbs() { 35 + protected function buildApplicationCrumbs() { 36 36 $crumbs = parent::buildApplicationCrumbs(); 37 37 38 38 $viewer = $this->getRequest()->getUser();
+1 -1
src/applications/phame/controller/PhameController.php
··· 103 103 return $stories; 104 104 } 105 105 106 - public function buildApplicationMenu() { 106 + protected function buildApplicationMenu() { 107 107 return $this->renderSideNavFilterView()->getMenu(); 108 108 } 109 109
+2 -2
src/applications/pholio/controller/PholioController.php
··· 21 21 return $nav; 22 22 } 23 23 24 - public function buildApplicationCrumbs() { 24 + protected function buildApplicationCrumbs() { 25 25 $crumbs = parent::buildApplicationCrumbs(); 26 26 27 27 $crumbs->addAction( ··· 33 33 return $crumbs; 34 34 } 35 35 36 - public function buildApplicationMenu() { 36 + protected function buildApplicationMenu() { 37 37 return $this->buildSideNavView(true)->getMenu(); 38 38 } 39 39
+1 -1
src/applications/phortune/controller/PhortuneCartListController.php
··· 79 79 return $nav; 80 80 } 81 81 82 - public function buildApplicationCrumbs() { 82 + protected function buildApplicationCrumbs() { 83 83 $crumbs = parent::buildApplicationCrumbs(); 84 84 85 85 $merchant = $this->merchant;
+1 -1
src/applications/phortune/controller/PhortuneChargeListController.php
··· 61 61 return $nav; 62 62 } 63 63 64 - public function buildApplicationCrumbs() { 64 + protected function buildApplicationCrumbs() { 65 65 $crumbs = parent::buildApplicationCrumbs(); 66 66 67 67 $account = $this->account;
+1 -1
src/applications/phortune/controller/PhortuneMerchantController.php
··· 3 3 abstract class PhortuneMerchantController 4 4 extends PhortuneController { 5 5 6 - public function buildApplicationCrumbs() { 6 + protected function buildApplicationCrumbs() { 7 7 $crumbs = parent::buildApplicationCrumbs(); 8 8 $crumbs->addTextCrumb( 9 9 pht('Merchants'),
+1 -1
src/applications/phortune/controller/PhortuneMerchantListController.php
··· 37 37 return $nav; 38 38 } 39 39 40 - public function buildApplicationCrumbs() { 40 + protected function buildApplicationCrumbs() { 41 41 $crumbs = parent::buildApplicationCrumbs(); 42 42 43 43 $can_create = $this->hasApplicationCapability(
+2 -2
src/applications/phriction/controller/PhrictionController.php
··· 22 22 return $nav; 23 23 } 24 24 25 - public function buildApplicationMenu() { 25 + protected function buildApplicationMenu() { 26 26 return $this->buildSideNavView(true)->getMenu(); 27 27 } 28 28 29 - public function buildApplicationCrumbs() { 29 + protected function buildApplicationCrumbs() { 30 30 $crumbs = parent::buildApplicationCrumbs(); 31 31 32 32 if (get_class($this) != 'PhrictionListController') {
+1 -1
src/applications/ponder/controller/PonderController.php
··· 17 17 return $nav; 18 18 } 19 19 20 - public function buildApplicationCrumbs() { 20 + protected function buildApplicationCrumbs() { 21 21 $crumbs = parent::buildApplicationCrumbs(); 22 22 $crumbs 23 23 ->addAction(
+2 -2
src/applications/project/controller/PhabricatorProjectListController.php
··· 22 22 return $this->delegateToController($controller); 23 23 } 24 24 25 - public function buildApplicationMenu() { 25 + protected function buildApplicationMenu() { 26 26 return $this->buildSideNavView(true)->getMenu(); 27 27 } 28 28 29 - public function buildApplicationCrumbs() { 29 + protected function buildApplicationCrumbs() { 30 30 $crumbs = parent::buildApplicationCrumbs(); 31 31 32 32 $can_create = $this->hasApplicationCapability(
+1 -1
src/applications/releeph/controller/ReleephController.php
··· 34 34 return $nav; 35 35 } 36 36 37 - public function buildApplicationMenu() { 37 + protected function buildApplicationMenu() { 38 38 return $this->buildSideNavView(true)->getMenu(); 39 39 } 40 40
+1 -1
src/applications/releeph/controller/branch/ReleephBranchViewController.php
··· 103 103 ->setViewer($this->getRequest()->getUser()); 104 104 } 105 105 106 - public function buildApplicationCrumbs() { 106 + protected function buildApplicationCrumbs() { 107 107 $crumbs = parent::buildApplicationCrumbs(); 108 108 109 109 $branch = $this->getBranch();
+1 -1
src/applications/releeph/controller/product/ReleephProductListController.php
··· 21 21 return $this->delegateToController($controller); 22 22 } 23 23 24 - public function buildApplicationCrumbs() { 24 + protected function buildApplicationCrumbs() { 25 25 $crumbs = parent::buildApplicationCrumbs(); 26 26 27 27 $crumbs->addAction(
+1 -1
src/applications/releeph/controller/product/ReleephProductViewController.php
··· 148 148 return $nav; 149 149 } 150 150 151 - public function buildApplicationCrumbs() { 151 + protected function buildApplicationCrumbs() { 152 152 $crumbs = parent::buildApplicationCrumbs(); 153 153 154 154 $product = $this->getProduct();
+1 -1
src/applications/settings/controller/PhabricatorSettingsMainController.php
··· 151 151 return $nav; 152 152 } 153 153 154 - public function buildApplicationMenu() { 154 + protected function buildApplicationMenu() { 155 155 $panels = $this->buildPanels(); 156 156 return $this->renderSideNav($panels)->getMenu(); 157 157 }
+2 -2
src/applications/slowvote/controller/PhabricatorSlowvoteController.php
··· 22 22 return $nav; 23 23 } 24 24 25 - public function buildApplicationMenu() { 25 + protected function buildApplicationMenu() { 26 26 return $this->buildSideNavView(true)->getMenu(); 27 27 } 28 28 29 - public function buildApplicationCrumbs() { 29 + protected function buildApplicationCrumbs() { 30 30 $crumbs = parent::buildApplicationCrumbs(); 31 31 32 32 $crumbs->addAction(
+2 -3
src/applications/tokens/controller/PhabricatorTokenController.php
··· 2 2 3 3 abstract class PhabricatorTokenController extends PhabricatorController { 4 4 5 - 6 5 protected function buildSideNav() { 7 6 $nav = new AphrontSideNavFilterView(); 8 7 $nav->setBaseURI(new PhutilURI($this->getApplicationURI())); ··· 14 13 return $nav; 15 14 } 16 15 17 - public function buildApplicationMenu() { 16 + protected function buildApplicationMenu() { 18 17 return $this->buildSideNav()->getMenu(); 19 18 } 20 19 21 - public function buildApplicationCrumbs() { 20 + protected function buildApplicationCrumbs() { 22 21 $crumbs = parent::buildApplicationCrumbs(); 23 22 return $crumbs; 24 23 }