@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Improve page titles for menu items that render in-context content
Summary: Ref T12174. Dashboards and "Home" currently use the page title "Configure Menu". Give them more appropriate titles instead.
Test Plan: Viewed dashboards, Home. Saw relevant page titles.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T12174
Differential Revision: https://secure.phabricator.com/D17281
+4
-3
+4
-3
src/applications/search/engine/PhabricatorProfileMenuEngine.php
+4
-3
src/applications/search/engine/PhabricatorProfileMenuEngine.php
···
214
214
}
215
215
}
216
216
}
217
+
$page_title = pht('Configure Menu');
218
+
} else {
219
+
$page_title = $selected_item->getDisplayName();
217
220
}
218
221
219
222
switch ($item_action) {
···
293
296
294
297
$crumbs->setBorder(true);
295
298
296
-
// TODO: This title is not correct when viewing items.
297
-
298
299
$page = $controller->newPage()
299
-
->setTitle(pht('Configure Menu'))
300
+
->setTitle($page_title)
300
301
->setCrumbs($crumbs)
301
302
->appendChild($content);
302
303