recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix for showing an unregistered author name in the tooltip of diffusion revision link

Summary:
When showing contents of a file with the blame mode enabled, tooltips pops out
when the mouse hovers over previous commit linkes on left side. The last part of the
tooltips is the author's name. If an author is unregistered, the name becomes
<span>name</span>.

{F147724}

This doesn't happen if the author is registered.

Test Plan:
Check tooltips after making the change.
{F147725}

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D8869

authored by

Kyle Jao and committed by
epriestley e8c6c81b 88ae2465

+1 -5
+1 -5
src/applications/diffusion/controller/DiffusionBrowseFileController.php
··· 538 538 if ($author_phid && $handles[$author_phid]) { 539 539 $author_link = $handles[$author_phid]->renderLink(); 540 540 } else { 541 - $author_link = phutil_tag( 542 - 'span', 543 - array( 544 - ), 545 - $blame['author']); 541 + $author_link = $blame['author']; 546 542 } 547 543 $display_line['author'] = $author_link; 548 544