@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Un-hide the "X added reviewers: ..." transactions in revision creation mail
Summary:
Fixes T12118. See PHI54. This adds a special case for the initial "reviewers" transactions, similar to the existing special case for "projects" transactions.
Although these transactions are redudnant in the web view since you can see the information clearly on the page, they're more reasonably useful in mail.
Test Plan: {F5168838}
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T12118
Differential Revision: https://secure.phabricator.com/D18542
+12
+12
src/applications/differential/storage/DifferentialTransaction.php
+12
src/applications/differential/storage/DifferentialTransaction.php
···
105
105
return parent::shouldHide();
106
106
}
107
107
108
+
public function shouldHideForMail(array $xactions) {
109
+
switch ($this->getTransactionType()) {
110
+
case DifferentialRevisionReviewersTransaction::TRANSACTIONTYPE:
111
+
// Don't hide the initial "X added reviewers: ..." transaction during
112
+
// object creation from mail. See T12118 and PHI54.
113
+
return false;
114
+
}
115
+
116
+
return parent::shouldHideForMail($xactions);
117
+
}
118
+
119
+
108
120
public function isInlineCommentTransaction() {
109
121
switch ($this->getTransactionType()) {
110
122
case self::TYPE_INLINE: