recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix the last remaining (?) continue inside switch

Summary: See <https://discourse.phabricator-community.org/t/error-on-project-creation-or-edition-with-php7-3/2236/>. This is the only remaining case that the linter rule in D19931 detected in libphutil, arcanist, or Phabricator.

Test Plan: Ran `arc lint --everything ...` in all three repositories, only hit this one.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D19932

epriestley e98ee736 b3faa287

+1 -1
+1 -1
src/applications/phriction/editor/PhrictionTransactionEditor.php
··· 351 351 switch ($type) { 352 352 case PhrictionDocumentContentTransaction::TRANSACTIONTYPE: 353 353 if ($xaction->getMetadataValue('stub:create:phid')) { 354 - continue; 354 + break; 355 355 } 356 356 357 357 if ($this->getProcessContentVersionError()) {