+2 -1

resources/sql/autopatches/20141222.maniphestprojtxn.php

reviewed

··· 6 6 echo "Converting Maniphest project transactions to modern EDGE ". 7 7 "transactions...\n"; 8 8 $metadata = array( 9 9 - 'edge:type' => PhabricatorProjectObjectHasProjectEdgeType::EDGECONST,); 9 9 + 'edge:type' => PhabricatorProjectObjectHasProjectEdgeType::EDGECONST, 10 10 + ); 10 11 foreach (new LiskMigrationIterator($table) as $txn) { 11 12 // ManiphestTransaction::TYPE_PROJECTS 12 13 if ($txn->getTransactionType() == 'projects') {

+2 -1

src/applications/auth/management/PhabricatorAuthManagementTrustOAuthClientWorkflow.php

reviewed

··· 18 18 'name' => 'id', 19 19 'param' => 'id', 20 20 'help' => pht('The id of the OAuth client.'), 21 21 - ),)); 21 21 + ), 22 22 + )); 22 23 } 23 24 24 25 public function execute(PhutilArgumentParser $args) {

+2 -1

src/applications/auth/management/PhabricatorAuthManagementUntrustOAuthClientWorkflow.php

reviewed

··· 18 18 'name' => 'id', 19 19 'param' => 'id', 20 20 'help' => pht('The id of the OAuth client.'), 21 21 - ),)); 21 21 + ), 22 22 + )); 22 23 } 23 24 24 25 public function execute(PhutilArgumentParser $args) {

+2 -1

src/applications/base/controller/PhabricatorController.php

reviewed

··· 256 256 if ($must_sign_docs) { 257 257 $controller = new LegalpadDocumentSignController(); 258 258 $this->getRequest()->setURIMap(array( 259 259 - 'id' => head($must_sign_docs)->getID(),)); 259 259 + 'id' => head($must_sign_docs)->getID(), 260 260 + )); 260 261 $this->setCurrentApplication($legalpad); 261 262 return $this->delegateToController($controller); 262 263 } else {

+4 -2

src/applications/conduit/controller/PhabricatorConduitAPIController.php

reviewed

··· 283 283 pht( 284 284 'This request originates from outside of the Phabricator '. 285 285 'cluster address range. Requests signed with trusted '. 286 286 - 'device keys must originate from within the cluster.'),); 286 286 + 'device keys must originate from within the cluster.'), 287 287 + ); 287 288 } 288 289 289 290 $user = PhabricatorUser::getOmnipotentUser(); ··· 384 385 pht( 385 386 'This request originates from outside of the Phabricator '. 386 387 'cluster address range. Requests signed with cluster API '. 387 387 - 'tokens must originate from within the cluster.'),); 388 388 + 'tokens must originate from within the cluster.'), 389 389 + ); 388 390 } 389 391 390 392 // Flag this as an intracluster request.

+13 -8

src/applications/config/check/PhabricatorBinariesSetupCheck.php

reviewed

··· 107 107 case PhabricatorRepositoryType::REPOSITORY_TYPE_SVN: 108 108 $minimum_version = '1.5'; 109 109 $bad_versions = array( 110 110 - '1.7.1' => pht('This version of Subversion has a bug where '. 111 111 - '"svn diff -c N" does not work for files added '. 112 112 - 'in rN (Subversion issue #2873), fixed in 1.7.2.'),); 110 110 + '1.7.1' => pht( 111 111 + 'This version of Subversion has a bug where `%s` does not work '. 112 112 + 'for files added in rN (Subversion issue #2873), fixed in 1.7.2.', 113 113 + 'svn diff -c N'), 114 114 + ); 113 115 list($err, $stdout, $stderr) = exec_manual('svn --version --quiet'); 114 116 $version = trim($stdout); 115 117 break; 116 118 case PhabricatorRepositoryType::REPOSITORY_TYPE_MERCURIAL: 117 119 $minimum_version = '1.9'; 118 120 $bad_versions = array( 119 119 - '2.1' => pht('This version of Mercurial returns a bad exit code '. 120 120 - 'after a successful pull.'), 121 121 - '2.2' => pht('This version of Mercurial has a significant memory '. 122 122 - 'leak, fixed in 2.2.1. Pushing fails with this '. 123 123 - 'version as well; see T3046#54922.'),); 121 121 + '2.1' => pht( 122 122 + 'This version of Mercurial returns a bad exit code '. 123 123 + 'after a successful pull.'), 124 124 + '2.2' => pht( 125 125 + 'This version of Mercurial has a significant memory leak, fixed '. 126 126 + 'in 2.2.1. Pushing fails with this version as well; see %s.', 127 127 + 'T3046#54922'), 128 128 + ); 124 129 $version = PhabricatorRepositoryVersion::getMercurialVersion(); 125 130 break; 126 131 }

+4 -2

src/applications/conpherence/__tests__/ConpherenceTestCase.php

reviewed

··· 9 9 10 10 $xactions = array(id(new ConpherenceTransaction()) 11 11 ->setTransactionType(ConpherenceTransactionType::TYPE_PARTICIPANTS) 12 12 - ->setNewValue(array('+' => $participant_phids)),); 12 12 + ->setNewValue(array('+' => $participant_phids)), 13 13 + ); 13 14 $editor = id(new ConpherenceEditor()) 14 15 ->setActor($actor) 15 16 ->setContentSource(PhabricatorContentSource::newConsoleSource()) ··· 24 25 25 26 $xactions = array(id(new ConpherenceTransaction()) 26 27 ->setTransactionType(ConpherenceTransactionType::TYPE_PARTICIPANTS) 27 27 - ->setNewValue(array('-' => $participant_phids)),); 28 28 + ->setNewValue(array('-' => $participant_phids)), 29 29 + ); 28 30 $editor = id(new ConpherenceEditor()) 29 31 ->setActor($actor) 30 32 ->setContentSource(PhabricatorContentSource::newConsoleSource())

+2 -1

src/applications/conpherence/controller/ConpherenceListController.php

reviewed

··· 125 125 ->execute(); 126 126 127 127 return array( 128 128 - 'all_participation' => $all_participation,); 128 128 + 'all_participation' => $all_participation, 129 129 + ); 129 130 } 130 131 131 132 private function loadConpherenceThreadData($participation) {

+2 -1

src/applications/conpherence/query/ConpherenceThreadSearchEngine.php

reviewed

··· 178 178 return array( 179 179 'rooms' => pht('Rooms'), 180 180 'messages' => pht('Messages'), 181 181 - 'both' => pht('Both'),); 181 181 + 'both' => pht('Both'), 182 182 + ); 182 183 } 183 184 184 185 }

+2 -1

src/applications/conpherence/storage/ConpherenceThread.php

reviewed

··· 60 60 ), 61 61 self::CONFIG_KEY_SCHEMA => array( 62 62 'key_room' => array( 63 63 - 'columns' => array('isRoom', 'dateModified'),), 63 63 + 'columns' => array('isRoom', 'dateModified'), 64 64 + ), 64 65 'key_phid' => null, 65 66 'phid' => array( 66 67 'columns' => array('phid'),

+8 -5

src/applications/conpherence/view/ConpherenceDurableColumnView.php

reviewed

··· 375 375 ), 376 376 $header), 377 377 $settings_button, 378 378 - $settings_menu,)); 379 379 - 378 378 + $settings_menu, 379 379 + )); 380 380 } 381 381 382 382 private function getHeaderActionsConfig(ConpherenceThread $conpherence) { ··· 418 418 'href' => '#', 419 419 'icon' => 'fa-times', 420 420 'key' => 'hide_column', 421 421 - ),); 421 421 + ), 422 422 + ); 422 423 } 423 424 424 425 private function buildTransactions() { ··· 441 442 'class' => 'button grey', 442 443 'sigil' => 'workflow', 443 444 ), 444 444 - pht('Send a Message')),); 445 445 + pht('Send a Message')), 446 446 + ); 445 447 } 446 448 447 449 $data = ConpherenceTransactionView::renderTransactions( ··· 501 503 'type' => 'hidden', 502 504 'name' => 'action', 503 505 'value' => ConpherenceUpdateActions::MESSAGE, 504 504 - )),)); 506 506 + )), 507 507 + )); 505 508 } 506 509 507 510 private function buildStatusText() {

+2 -1

src/applications/differential/application/PhabricatorDifferentialApplication.php

reviewed

··· 179 179 phutil_tag( 180 180 'a', 181 181 array( 182 182 - 'href' => $this->getInboundEmailSupportLink(),), 182 182 + 'href' => $this->getInboundEmailSupportLink(), 183 183 + ), 183 184 pht('Learn More'))); 184 185 } 185 186

+4 -2

src/applications/differential/conduit/DifferentialCreateDiffConduitAPIMethod.php

reviewed

··· 163 163 $request->getValue('sourceControlBaseRevision'), 164 164 'arcanistProjectPHID' => $project_phid, 165 165 'lintStatus' => $lint_status, 166 166 - 'unitStatus' => $unit_status,); 166 166 + 'unitStatus' => $unit_status, 167 167 + ); 167 168 168 169 $xactions = array(id(new DifferentialTransaction()) 169 170 ->setTransactionType(DifferentialDiffTransaction::TYPE_DIFF_CREATE) 170 170 - ->setNewValue($diff_data_dict),); 171 171 + ->setNewValue($diff_data_dict), 172 172 + ); 171 173 172 174 id(new DifferentialDiffEditor()) 173 175 ->setActor($viewer)

+4 -2

src/applications/differential/conduit/DifferentialCreateRawDiffConduitAPIMethod.php

reviewed

··· 53 53 'authorPHID' => $viewer->getPHID(), 54 54 'repositoryPHID' => $repository_phid, 55 55 'lintStatus' => DifferentialLintStatus::LINT_SKIP, 56 56 - 'unitStatus' => DifferentialUnitStatus::UNIT_SKIP,); 56 56 + 'unitStatus' => DifferentialUnitStatus::UNIT_SKIP, 57 57 + ); 57 58 58 59 $xactions = array(id(new DifferentialTransaction()) 59 60 ->setTransactionType(DifferentialDiffTransaction::TYPE_DIFF_CREATE) 60 60 - ->setNewValue($diff_data_dict),); 61 61 + ->setNewValue($diff_data_dict), 62 62 + ); 61 63 62 64 if ($request->getValue('viewPolicy')) { 63 65 $xactions[] = id(new DifferentialTransaction())

+4 -2

src/applications/differential/controller/DifferentialRevisionCloseDetailsController.php

reviewed

··· 62 62 phutil_tag( 63 63 'a', 64 64 array( 65 65 - 'href' => $obj_handle->getURI(),), 65 65 + 'href' => $obj_handle->getURI(), 66 66 + ), 66 67 $obj_handle->getName())); 67 68 } else if ($revision_match_data['foundURI']) { 68 69 $body_why[] = pht( ··· 96 97 $diff_link = phutil_tag( 97 98 'a', 98 99 array( 99 99 - 'href' => $obj_handle->getURI(),), 100 100 + 'href' => $obj_handle->getURI(), 101 101 + ), 100 102 $obj_handle->getName()); 101 103 $body_why = pht( 102 104 'This commit and the active diff of %s had the same %s hash '.

+2 -1

src/applications/differential/mail/DifferentialCreateMailReceiver.php

reviewed

··· 59 59 $call = new ConduitCall( 60 60 'differential.createrawdiff', 61 61 array( 62 62 - 'diff' => $body,)); 62 62 + 'diff' => $body, 63 63 + )); 63 64 $call->setUser($sender); 64 65 try { 65 66 $result = $call->execute();

+2 -1

src/applications/files/application/PhabricatorFilesApplication.php

reviewed

··· 51 51 phutil_tag( 52 52 'a', 53 53 array( 54 54 - 'href' => $this->getInboundEmailSupportLink(),), 54 54 + 'href' => $this->getInboundEmailSupportLink(), 55 55 + ), 55 56 pht('Learn More'))); 56 57 } 57 58

+2 -1

src/applications/maniphest/application/PhabricatorManiphestApplication.php

reviewed

··· 122 122 phutil_tag( 123 123 'a', 124 124 array( 125 125 - 'href' => $this->getInboundEmailSupportLink(),), 125 125 + 'href' => $this->getInboundEmailSupportLink(), 126 126 + ), 126 127 pht('Learn More'))); 127 128 } 128 129

+2 -1

src/applications/paste/application/PhabricatorPasteApplication.php

reviewed

··· 55 55 phutil_tag( 56 56 'a', 57 57 array( 58 58 - 'href' => $this->getInboundEmailSupportLink(),), 58 58 + 'href' => $this->getInboundEmailSupportLink(), 59 59 + ), 59 60 pht('Learn More'))); 60 61 } 61 62

+2 -1

src/applications/phriction/controller/PhrictionDocumentController.php

reviewed

··· 376 376 $child_dict = array( 377 377 'slug' => $child->getSlug(), 378 378 'depth' => $child->getDepth(), 379 379 - 'title' => $child->getContent()->getTitle(),); 379 379 + 'title' => $child->getContent()->getTitle(), 380 380 + ); 380 381 if ($child->getDepth() == $d_child) { 381 382 $children_dicts[] = $child_dict; 382 383 continue;

+4 -2

src/applications/phriction/editor/PhrictionTransactionEditor.php

reviewed

··· 132 132 'id' => $document->getID(), 133 133 'phid' => $document->getPHID(), 134 134 'content' => $document->getContent()->getContent(), 135 135 - 'title' => $document->getContent()->getTitle(),); 135 135 + 'title' => $document->getContent()->getTitle(), 136 136 + ); 136 137 return $dict; 137 138 case PhrictionTransaction::TYPE_MOVE_AWAY: 138 139 $document = $xaction->getNewValue(); ··· 140 141 'id' => $document->getID(), 141 142 'phid' => $document->getPHID(), 142 143 'content' => $document->getContent()->getContent(), 143 143 - 'title' => $document->getContent()->getTitle(),); 144 144 + 'title' => $document->getContent()->getTitle(), 145 145 + ); 144 146 return $dict; 145 147 } 146 148 }

+2 -1

src/applications/policy/config/PhabricatorPolicyConfigOptions.php

reviewed

··· 22 22 public function getOptions() { 23 23 $policy_locked_type = 'custom:PolicyLockOptionType'; 24 24 $policy_locked_example = array( 25 25 - 'people.create.users' => 'admin',); 25 25 + 'people.create.users' => 'admin', 26 26 + ); 26 27 $json = new PhutilJSON(); 27 28 $policy_locked_example = $json->encodeFormatted($policy_locked_example); 28 29

+2 -1

src/applications/transactions/controller/PhabricatorApplicationTransactionShowOlderController.php

reviewed

··· 49 49 50 50 return id(new AphrontAjaxResponse()) 51 51 ->setContent(array( 52 52 - 'timeline' => hsprintf('%s', $events),)); 52 52 + 'timeline' => hsprintf('%s', $events), 53 53 + )); 53 54 } 54 55 55 56 }

+2 -1

src/infrastructure/diff/view/PhabricatorInlineSummaryView.php

reviewed

··· 39 39 ), 40 40 array( 41 41 $icon, 42 42 - $group,)); 42 42 + $group, 43 43 + )); 43 44 $rows[] = phutil_tag('tr', array(), $header); 44 45 45 46 foreach ($items as $item) {

+2 -1

src/view/control/AphrontTableView.php

reviewed

··· 305 305 $html = phutil_tag( 306 306 'table', 307 307 array( 308 308 - 'class' => implode(' ', $classes),), 308 308 + 'class' => implode(' ', $classes), 309 309 + ), 309 310 $table); 310 311 return phutil_tag_div('aphront-table-wrap', $html); 311 312 }

+2 -1

src/view/form/control/AphrontFormControl.php

reviewed

··· 212 212 ), 213 213 array( 214 214 $this->getLabel(), 215 215 - $error,)); 215 215 + $error, 216 216 + )); 216 217 } else { 217 218 $label = null; 218 219 $custom_class .= ' aphront-form-control-nolabel';

+4 -2

src/view/layout/PhabricatorTransactionView.php

reviewed

··· 81 81 array( 82 82 $image, 83 83 phutil_tag_div('phabricator-transaction-detail grouped', 84 84 - array($header, $content)),)); 84 84 + array($header, $content)), 85 85 + )); 85 86 86 87 } 87 88 ··· 129 130 return phutil_tag( 130 131 'span', 131 132 array( 132 132 - 'class' => 'phabricator-transaction-info',), 133 133 + 'class' => 'phabricator-transaction-info', 134 134 + ), 133 135 $info); 134 136 } 135 137

+2 -1

src/view/phui/PHUIDocumentView.php

reviewed

··· 174 174 'map' => array( 175 175 $this->actionListID => 'phabricator-action-list-toggle', 176 176 $icon_id => 'phuix-dropdown-open', 177 177 - ),); 177 177 + ), 178 178 + ); 178 179 $mobile_menu = id(new PHUIButtonView()) 179 180 ->setTag('a') 180 181 ->setText(pht('Actions'))

+2 -1

src/view/phui/PHUIObjectBoxView.php

reviewed

··· 171 171 'map' => array( 172 172 $this->actionListID => 'phabricator-action-list-toggle', 173 173 $icon_id => 'phuix-dropdown-open', 174 174 - ),); 174 174 + ), 175 175 + ); 175 176 $mobile_menu = id(new PHUIButtonView()) 176 177 ->setTag('a') 177 178 ->setText(pht('Actions'))

+2 -1

src/view/phui/PHUIObjectItemView.php

reviewed

··· 581 581 ), 582 582 array( 583 583 $icons, 584 584 - $bylines,)); 584 584 + $bylines, 585 585 + )); 585 586 } 586 587 587 588 $table = phutil_tag(

+4 -2

src/view/phui/PHUITimelineEventView.php

reviewed

··· 435 435 'class' => 'phui-timeline-event-view '. 436 436 'phui-timeline-spacer '. 437 437 'phui-timeline-spacer-bold', 438 438 - '',)); 438 438 + '', 439 439 + )); 439 440 } 440 441 441 442 return array( ··· 453 454 'class' => implode(' ', $classes), 454 455 ), 455 456 $content)), 456 456 - $major_event,); 457 457 + $major_event, 458 458 + ); 457 459 } 458 460 459 461 private function renderExtra(array $events) {