recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix issue where "{Fnnn, size}" renders as though "size=full"

Summary: We interpret "size" as "size => true", and "true == 'full'", so we hit the wrong branch in the switch(). String cast explicitly.

Test Plan: Typed `{Fnnn, size}`; saw it render as a thumb instead of full.

Reviewers: btrahan, codeblock

Reviewed By: codeblock

CC: frozendevil, aran

Differential Revision: https://secure.phabricator.com/D4323

epriestley ea52c30b a3fdb20a

+1 -1
+1 -1
src/infrastructure/markup/rule/PhabricatorRemarkupRuleEmbedFile.php
··· 50 50 $options['name'] = $file_name; 51 51 52 52 $attrs = array(); 53 - switch ($options['size']) { 53 + switch ((string)$options['size']) { 54 54 case 'full': 55 55 $attrs['src'] = $file->getBestURI(); 56 56 $options['image_class'] = null;