@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix an issue with multiple "open" statuses and the "View All" button on Projects
Summary: See IRC. We construct this a little bit wrong if there are multiple "open" statuses. Use a more modern construction.
Test Plan: Hit `?statuses=wontfix,invalid`, etc. Clicked "view all" from projects.
Reviewers: btrahan, chad
Reviewed By: chad
Subscribers: epriestley
Differential Revision: https://secure.phabricator.com/D8854
+10
-4
+8
-2
src/applications/maniphest/query/ManiphestTaskSearchEngine.php
+8
-2
src/applications/maniphest/query/ManiphestTaskSearchEngine.php
···
24
24
'subscriberPHIDs',
25
25
$this->readPHIDsFromRequest($request, 'subscribers'));
26
26
27
-
$saved->setParameter('statuses', $request->getArr('statuses'));
28
-
$saved->setParameter('priorities', $request->getArr('priorities'));
27
+
$saved->setParameter(
28
+
'statuses',
29
+
$this->readListFromRequest($request, 'statuses'));
30
+
31
+
$saved->setParameter(
32
+
'priorities',
33
+
$this->readListFromRequest($request, 'priorities'));
34
+
29
35
$saved->setParameter('group', $request->getStr('group'));
30
36
$saved->setParameter('order', $request->getStr('order'));
31
37
+2
-2
src/applications/project/controller/PhabricatorProjectProfileController.php
+2
-2
src/applications/project/controller/PhabricatorProjectProfileController.php
···
147
147
$task_list->setHandles($handles);
148
148
149
149
$phid = $project->getPHID();
150
-
$view_uri = sprintf(
151
-
'/maniphest/?statuses[]=%s&allProjects[]=%s#R',
150
+
$view_uri = urisprintf(
151
+
'/maniphest/?statuses=%s&allProjects[]=%s#R',
152
152
implode(',', ManiphestTaskStatus::getOpenStatusConstants()),
153
153
$phid);
154
154
$create_uri = '/maniphest/task/create/?projects='.$phid;