@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix a qsprintf() issue in mail queries
Summary: Ref T920. Bumped into this while looking at SMS support.
Test Plan: Loaded `/mail/`, no more `qsprintf()` warning.
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T920
Differential Revision: https://secure.phabricator.com/D19936
+3
-3
+3
-3
src/applications/metamta/query/PhabricatorMetaMTAMailQuery.php
+3
-3
src/applications/metamta/query/PhabricatorMetaMTAMailQuery.php
···
99
99
return $where;
100
100
}
101
101
102
-
protected function buildJoinClause(AphrontDatabaseConnection $conn) {
103
-
$joins = array();
102
+
protected function buildJoinClauseParts(AphrontDatabaseConnection $conn) {
103
+
$joins = parent::buildJoinClauseParts($conn);
104
104
105
105
if ($this->actorPHIDs === null && $this->recipientPHIDs === null) {
106
106
$joins[] = qsprintf(
···
119
119
PhabricatorMetaMTAMailHasRecipientEdgeType::EDGECONST);
120
120
}
121
121
122
-
return implode(' ', $joins);
122
+
return $joins;
123
123
}
124
124
125
125
protected function getPrimaryTableAlias() {