@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Add some icons/color to Config Settings UI
Summary: This adds status icons, locked, hidden, editable, customized, to the list of options in config. Makes it easier to read and assertain state.
Test Plan:
View a hidden, customized, editable, and locked.
{F1796320}
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D16475
+38
-15
+3
-3
resources/celerity/map.php
+3
-3
resources/celerity/map.php
···
7
7
*/
8
8
return array(
9
9
'names' => array(
10
-
'core.pkg.css' => 'ffbade6c',
10
+
'core.pkg.css' => 'ad6a3591',
11
11
'core.pkg.js' => '2b8af4e4',
12
12
'darkconsole.pkg.js' => 'e7393ebb',
13
13
'differential.pkg.css' => '3fb7f532',
···
148
148
'rsrc/css/phui/phui-info-view.css' => '28efab79',
149
149
'rsrc/css/phui/phui-list.css' => '9da2aa00',
150
150
'rsrc/css/phui/phui-object-box.css' => '6b487c57',
151
-
'rsrc/css/phui/phui-object-item-list-view.css' => '987db9bf',
151
+
'rsrc/css/phui/phui-object-item-list-view.css' => '87278fa0',
152
152
'rsrc/css/phui/phui-pager.css' => 'bea33d23',
153
153
'rsrc/css/phui/phui-pinboard-view.css' => '2495140e',
154
154
'rsrc/css/phui/phui-profile-menu.css' => '8a3fc181',
···
858
858
'phui-inline-comment-view-css' => '5953c28e',
859
859
'phui-list-view-css' => '9da2aa00',
860
860
'phui-object-box-css' => '6b487c57',
861
-
'phui-object-item-list-view-css' => '987db9bf',
861
+
'phui-object-item-list-view-css' => '87278fa0',
862
862
'phui-pager-css' => 'bea33d23',
863
863
'phui-pinboard-view-css' => '2495140e',
864
864
'phui-profile-menu-css' => '8a3fc181',
+19
-12
src/applications/config/controller/PhabricatorConfigGroupController.php
+19
-12
src/applications/config/controller/PhabricatorConfigGroupController.php
···
77
77
->setHref('/config/edit/'.$option->getKey().'/')
78
78
->addAttribute($summary);
79
79
80
+
$label = pht('Current Value:');
81
+
$color = null;
82
+
$db_value = idx($db_values, $option->getKey());
83
+
if ($db_value && !$db_value->getIsDeleted()) {
84
+
$item->setEffect('visited');
85
+
$color = 'violet';
86
+
$label = pht('Customized Value:');
87
+
}
88
+
89
+
if ($option->getHidden()) {
90
+
$item->setStatusIcon('fa-eye-slash grey', pht('Hidden'));
91
+
$item->setDisabled(true);
92
+
} else if ($option->getLocked()) {
93
+
$item->setStatusIcon('fa-lock '.$color, pht('Locked'));
94
+
} else {
95
+
$item->setStatusIcon('fa-pencil-square-o '.$color, pht('Editable'));
96
+
}
97
+
80
98
if (!$option->getHidden()) {
81
99
$current_value = PhabricatorEnv::getEnvConfig($option->getKey());
82
100
$current_value = PhabricatorConfigJSON::prettyPrintJSON(
···
87
105
'class' => 'config-options-current-value',
88
106
),
89
107
array(
90
-
phutil_tag('span', array(), pht('Current Value:')),
108
+
phutil_tag('span', array(), $label),
91
109
' '.$current_value,
92
110
));
93
111
94
112
$item->appendChild($current_value);
95
-
}
96
-
97
-
$db_value = idx($db_values, $option->getKey());
98
-
if ($db_value && !$db_value->getIsDeleted()) {
99
-
$item->addIcon('fa-edit', pht('Customized'));
100
-
}
101
-
102
-
if ($option->getHidden()) {
103
-
$item->addIcon('fa-eye-slash', pht('Hidden'));
104
-
} else if ($option->getLocked()) {
105
-
$item->addIcon('fa-lock', pht('Locked'));
106
113
}
107
114
108
115
$list->addItem($item);
+3
src/view/phui/PHUIObjectItemView.php
+3
src/view/phui/PHUIObjectItemView.php
+13
webroot/rsrc/css/phui/phui-object-item-list-view.css
+13
webroot/rsrc/css/phui/phui-object-item-list-view.css
···
772
772
margin-bottom: 8px;
773
773
}
774
774
775
+
.phui-object-list-big .phui-object-item-col0 {
776
+
vertical-align: top;
777
+
padding: 0;
778
+
}
779
+
780
+
.phui-object-list-big .phui-object-item-status-icon {
781
+
padding: 5px;
782
+
}
783
+
784
+
.phui-object-list-big .phui-object-item-visited a.phui-object-item-link {
785
+
color: {$violet};
786
+
}
787
+
775
788
.device-desktop .phui-object-list-big .phui-object-item-frame:hover {
776
789
777
790
}