recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

LEFT JOIN instead of JOIN for ApplicationSearch ordering

Summary: Ref T4659. Because we JOIN, tasks with no value are filtered out. Instead, LEFT JOIN.

Test Plan: Issued an "Order by" and got all applicable tasks. Adjusted values and saw order change.

Reviewers: btrahan, hach-que

Reviewed By: hach-que

Subscribers: epriestley

Maniphest Tasks: T4659

Differential Revision: https://secure.phabricator.com/D10119

epriestley eafd7070 c4586664

+1 -1
+1 -1
src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php
··· 570 570 571 571 $joins[] = qsprintf( 572 572 $conn_r, 573 - 'JOIN %T %T ON %T.objectPHID = %Q 573 + 'LEFT JOIN %T %T ON %T.objectPHID = %Q 574 574 AND %T.indexKey = %s', 575 575 $table, 576 576 $alias,