@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Construct diffs with attached changesets, even if empty
Summary: See discussion in IRC. Not 100% sure what's going on here because of email ghost theives, but conceivably a commit with no changes will end up with `null` changesets instead of `array()` changesets, which throws. Such diffs are certianly possible (`git commit --allow-empty`) even if they aren't the issue in this specific case. See T3416. Initialize changesets to `array()` to avoid throwing.
Test Plan:
Viewed some commits?
iiam
Reviewers: btrahan, chad
Reviewed By: chad
CC: aran
Differential Revision: https://secure.phabricator.com/D6339
+4
+4
src/applications/differential/storage/DifferentialDiff.php
+4
src/applications/differential/storage/DifferentialDiff.php
···
115
115
assert_instances_of($changes, 'ArcanistDiffChange');
116
116
$diff = new DifferentialDiff();
117
117
118
+
// There may not be any changes; initialize the changesets list so that
119
+
// we don't throw later when accessing it.
120
+
$diff->attachChangesets(array());
121
+
118
122
$lines = 0;
119
123
foreach ($changes as $change) {
120
124
if ($change->getType() == ArcanistDiffChangeType::TYPE_MESSAGE) {