recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Make alert icons stay white while menus are open

Summary: I think this is what you're after?

Test Plan: clicky clicky

Reviewers: chad

Reviewed By: chad

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D10966

epriestley eb9c3c66 aeb4267b

+25 -15
+13 -13
resources/celerity/map.php
··· 8 8 return array( 9 9 'names' => array( 10 10 'core.pkg.css' => 'a157f664', 11 - 'core.pkg.js' => '7c53868c', 11 + 'core.pkg.js' => 'e4556c9b', 12 12 'darkconsole.pkg.js' => 'df001cab', 13 13 'differential.pkg.css' => '8af45893', 14 14 'differential.pkg.js' => '42c10e78', ··· 348 348 'rsrc/image/texture/table_header_hover.png' => '038ec3b9', 349 349 'rsrc/image/texture/table_header_tall.png' => 'd56b434f', 350 350 'rsrc/js/application/aphlict/Aphlict.js' => '4a07e8e3', 351 - 'rsrc/js/application/aphlict/behavior-aphlict-dropdown.js' => '7d4cc76c', 351 + 'rsrc/js/application/aphlict/behavior-aphlict-dropdown.js' => '72118e8b', 352 352 'rsrc/js/application/aphlict/behavior-aphlict-listen.js' => 'a826c925', 353 353 'rsrc/js/application/aphlict/behavior-aphlict-status.js' => '58f7803f', 354 354 'rsrc/js/application/auth/behavior-persona-login.js' => '9414ff18', ··· 542 542 'inline-comment-summary-css' => '8cfd34e8', 543 543 'javelin-aphlict' => '4a07e8e3', 544 544 'javelin-behavior' => '61cbc29a', 545 - 'javelin-behavior-aphlict-dropdown' => '7d4cc76c', 545 + 'javelin-behavior-aphlict-dropdown' => '72118e8b', 546 546 'javelin-behavior-aphlict-listen' => 'a826c925', 547 547 'javelin-behavior-aphlict-status' => '58f7803f', 548 548 'javelin-behavior-aphront-basic-tokenizer' => 'b3a4b884', ··· 1278 1278 'phabricator-phtize', 1279 1279 'changeset-view-manager', 1280 1280 ), 1281 + '72118e8b' => array( 1282 + 'javelin-behavior', 1283 + 'javelin-request', 1284 + 'javelin-stratcom', 1285 + 'javelin-vector', 1286 + 'javelin-dom', 1287 + 'javelin-uri', 1288 + 'javelin-behavior-device', 1289 + 'phabricator-title', 1290 + ), 1281 1291 '724b1247' => array( 1282 1292 'javelin-behavior', 1283 1293 'javelin-typeahead-ondemand-source', ··· 1342 1352 'javelin-util', 1343 1353 'javelin-request', 1344 1354 'javelin-router', 1345 - ), 1346 - '7d4cc76c' => array( 1347 - 'javelin-behavior', 1348 - 'javelin-request', 1349 - 'javelin-stratcom', 1350 - 'javelin-vector', 1351 - 'javelin-dom', 1352 - 'javelin-uri', 1353 - 'javelin-behavior-device', 1354 - 'phabricator-title', 1355 1355 ), 1356 1356 '7e41274a' => array( 1357 1357 'javelin-install',
+4 -2
src/view/page/menu/PhabricatorMainMenuView.php
··· 316 316 ), 317 317 $message_count_number); 318 318 319 - $message_icon_tag = phutil_tag( 319 + $message_icon_tag = javelin_tag( 320 320 'span', 321 321 array( 322 322 'class' => 'phabricator-main-menu-message-icon phui-icon-view '. 323 323 'phui-font-fa fa-comments', 324 + 'sigil' => 'menu-icon', 324 325 ), 325 326 ''); 326 327 ··· 401 402 ), 402 403 $count_number); 403 404 404 - $icon_tag = phutil_tag( 405 + $icon_tag = javelin_tag( 405 406 'span', 406 407 array( 407 408 'class' => 'phabricator-main-menu-alert-icon phui-icon-view '. 408 409 'phui-font-fa fa-bell', 410 + 'sigil' => 'menu-icon', 409 411 ), 410 412 ''); 411 413
+8
webroot/rsrc/js/application/aphlict/behavior-aphlict-dropdown.js
··· 16 16 17 17 var dropdown = JX.$(config.dropdownID); 18 18 var bubble = JX.$(config.bubbleID); 19 + var icon = JX.DOM.scry(bubble, 'span', 'menu-icon')[0]; 19 20 20 21 var count; 21 22 if (config.countID) { ··· 69 70 if (!e.getNode('phabricator-notification-menu')) { 70 71 // Click outside the dropdown; hide it. 71 72 JX.DOM.hide(dropdown); 73 + if (icon) { 74 + JX.DOM.alterClass(icon, 'white', false); 75 + } 72 76 statics.visible = null; 73 77 return; 74 78 } ··· 140 144 p.setPos(dropdown); 141 145 142 146 statics.visible = dropdown; 147 + 148 + if (icon) { 149 + JX.DOM.alterClass(icon, 'white', true); 150 + } 143 151 } 144 152 ); 145 153