recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Missing optional Conduit arguments do not throw errors anymore.

Summary:
ConduitAPIRequest::getValue call for optional arguments which are
not given added a line to the error log file.

Test Plan:
Tested that Conduit API calls were working from Conduit console.

Reviewed By: epriestley
Reviewers: jungejason, epriestley
Commenters: jungejason
CC: epriestley, aran, jungejason
Differential Revision: 236

tuomaspelkonen ebbd5777 80eb0f0e

+3 -1
+1 -1
src/applications/conduit/protocol/request/ConduitAPIRequest.php
··· 26 26 } 27 27 28 28 public function getValue($key) { 29 - return $this->params[$key]; 29 + return idx($this->params, $key); 30 30 } 31 31 32 32 public function getAllParameters() {
+2
src/applications/conduit/protocol/request/__init__.php
··· 6 6 7 7 8 8 9 + phutil_require_module('phutil', 'utils'); 10 + 9 11 10 12 phutil_require_source('ConduitAPIRequest.php');