recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

render_tag -> tag: final block

Summary:
Convert a final few `render_tag()` calls to `tag()` calls. This leaves us with 36 calls:

- 9 are in Conpherence, and will be converted after merging. Using Views makes the most sense here, to get access to renderHTMLView() and such.
- 2 are the definition and its library map entry.
- 3 are in the documentation.
- I believe the remaining 22 are too difficult to convert pre-merge. About half are in code which is slated for destruction; the other half are in the base implementations of very common classes (like PhabricatorStandardPageView) and can only be converted by converting the entire codebase.

My plan at this point is:

- Test the branch thoroughly.
- Merge to master.
- Over time, resolve the remaining issues: lint means things shouldn't get any worse.

Test Plan: See inlines.

Reviewers: vrana

Reviewed By: vrana

CC: aran, edward

Maniphest Tasks: T2432

Differential Revision: https://secure.phabricator.com/D4802

epriestley ebc2937d 0f1bdbe1

+17 -23
+12 -18
src/applications/ponder/view/PonderPostBodyView.php
··· 56 56 $target->getMarkupField(), 57 57 $this->user); 58 58 59 - $content = 60 - '<div class="phabricator-remarkup">'. 61 - $content. 62 - '</div>'; 59 + $content = phutil_tag( 60 + 'div', 61 + array( 62 + 'class' => 'phabricator-remarkup', 63 + ), 64 + $content); 63 65 64 66 $author = $this->handles[$target->getAuthorPHID()]; 65 67 $actions = array($author->renderLink().' '.$this->action); ··· 88 90 } 89 91 90 92 $xaction_view->appendChild( 91 - '<div class="ponder-post-core">'. 92 - $content. 93 - '</div>' 94 - ); 93 + phutil_tag( 94 + 'div', 95 + array( 96 + 'class' => 'ponder-post-core', 97 + ), 98 + $content)); 95 99 96 100 $outerview = $xaction_view; 97 101 if (!$this->preview) { ··· 112 116 113 117 return $outerview->render(); 114 118 } 115 - 116 - private function renderHandleList(array $phids) { 117 - $result = array(); 118 - foreach ($phids as $phid) { 119 - $result[] = $this->handles[$phid]->renderLink(); 120 - } 121 - return implode(', ', $result); 122 - } 123 - 124 - 125 119 126 120 }
+1 -1
src/applications/repository/controller/PhabricatorRepositoryListController.php
··· 113 113 'class' => 'button grey small', 114 114 ), 115 115 'Edit'), 116 - javelin_render_tag( 116 + javelin_tag( 117 117 'a', 118 118 array( 119 119 'href' => '/repository/project/delete/'.$project->getID().'/',
+1 -1
src/view/layout/AphrontPanelView.php
··· 15 15 16 16 public function setCreateButton($create_button, $href) { 17 17 $this->addButton( 18 - phutil_render_tag( 18 + phutil_tag( 19 19 'a', 20 20 array( 21 21 'href' => $href,
+1 -1
src/view/layout/PhabricatorMenuView.php
··· 159 159 } 160 160 161 161 protected function getTagContent() { 162 - return $this->renderSingleView($this->items); 162 + return $this->renderHTMLView($this->items); 163 163 } 164 164 }
+2 -2
src/view/layout/PhabricatorTimelineView.php
··· 27 27 } 28 28 $events[] = $spacer; 29 29 30 - return phutil_render_tag( 30 + return phutil_tag( 31 31 'div', 32 32 array( 33 33 'class' => 'phabricator-timeline-view', 34 34 'id' => $this->id, 35 35 ), 36 - implode('', $events)); 36 + $events); 37 37 } 38 38 39 39 public static function renderSpacer() {